Conversation
….21.2+ compatibility
Contributor
Author
|
Updating to For future reference, the PR which hopefully fixes this in a future lightning library release: alexbosworth/lightning#214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When connected to LND nodes running v0.21.2+,
subscribe_to_channelsin thelightningpackage can receive subscription update events whereupdate.typeis undefined or missing, or details for the event type are omitted.Currently, this causes
subscribe_to_channelsto emit fatal errors:ExpectedEventTypeInChannelSubscriptionExpectedEventDetailsForTypeInChannelSubThese unhandled errors crash the channel subscription listener service in ThunderHub.
Solution
Add
patches/lightning+11.1.0.patch(applied automatically via existingpatch-packageon postinstall):updateActive,updateInactive,updateClosed,updateOpened,updateOpening) ifupdate.typeis not explicitly populated.Verification
patch-packagecleanly applieslightning@11.1.0.