Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Amboss API is repeatedly queried for node alias and edge fee info, from separate UI widgets simulatneously, resulting in quite a lot of latency and can possibly overwhelms or rate limits the Amboss API.
This PR adds an in-memory TTL cache. Cache policies are to be discussed, but for now:
Currently it's using a simple FIFO eviction policy, it's possible to hook up
lru-cache, which is a transient dependency of Apollo and Jest, but that might be overkill here. I don't think there are 5000 channel nodes out there.This PR also adds de-duplication of requests, in case multiple concurrent requests ask for the same edge data or alias. Cache misses are held for an hour.