fix(relay): apply host Unix socket permissions - #909
Open
stephenlclarke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
UnixSocketConfiguration.permissionswhen an.outOfUnixSocketRelaycreates its host-side listener.The
.intopath already forwards the configured mode toUnixType, but.outOfomitted it and therefore used the process-default socket mode. A caller requesting a private endpoint such as0600could receive broader permissions than requested.Extract the host-listener construction into a package-visible helper so the filesystem contract can be tested without a VM, pass the optional mode through, and close the new socket if
listen()fails.Testing
swift test --filter UnixSocketRelayTestsResult: 1 focused regression passed, verifying that an
.outOfrelay configured with0600creates a host socket with mode0600.Compatibility
Callers that omit
permissionskeep the existing default. Callers that provide a mode now receive the documented behavior consistently in both relay directions.