Repository navigation
Conversation
Contributor
Author
This is expected since Once we merge, the CI failure will go away. |
jrflat
marked this pull request as ready for review
September 30, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System previously imported CSystem with a bare (public) import. As a result, building with library evolution (e.g. as an OS framework) added
import CSystemto System's.swiftinterface, which then failed to verify with "no such module 'CSystem'". On Darwin,_O_CLOFORK's inlinable body also referenced a macro defined in CSystem.Switching to internal imports alone doesn't work:
CSystemLinux.hre-included glibc headers, which made CSystem a second owner of declarations likeEPERMandmode_t. These declarations would then be treated as internal and couldn't be used inside inlinable code. Now:CSystemLinux.hno longer re-includes libc headers that Glibc exports. Those declarations are now attributed to the libc module.Constants.swifton WASI and FreeBSD, whose inlinable constants still come from CSystem.IORing'sio_uringtypes move to a new CSystemIOUring module, which theIORingfiles import publicly. The syscall wrappers move intoshims.c._O_CLOFORKis now the literal0x0800_0000, since older SDKs lackO_CLOFORK, andCSystemDarwin.his removed. A new test checks the literal against the SDK'sO_CLOFORK.CSystemWindows.his removed.CInterop.swiftimports Android instead of Bionic, like the other files.