Repository navigation
Fix missing done in IORing.blockingConsumeCompletions - #393
Merged
Merged
Conversation
FranzBusch
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blockingConsumeCompletionsandsubmitPreparedRequestsAndConsumeCompletionsonly sent their finaldonewhen they had to wait for completions. When enough completions (>= minimumCount) were already in the ring, the functions returned without sendingdone, so a consumer that relies on it (e.g. to finish a batch) never got it.This PR moves the
consumer(nil, nil, true)call out of theif count < minimumCountbranch. ThemaximumCountand timeout paths senddoneand return before reaching it, soblockingConsumeCompletionsstill sends it exactly once.This also means that with
minimumCount: 0and an empty ring, the consumer now gets a singledone. Previously, the consumer wasn't called at all, so this is a behavior change but I believe a good one.Added test fails without the fix.