fix: align CAPI readiness and convergence retry contracts - #16
Draft
reoring wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status.conditionsstallTimeoutsupport for callers with a safe progress invariantRoot cause
Kest 0.18.0 had two runtime contract mismatches:
useClusterexpectedstatus.v1beta2.conditions, but a servedcluster.x-k8s.io/v1beta2Cluster exposes metav1 conditions atstatus.conditions.RemoteConnectionProbeand rollout conditions unchanged for more than 30 seconds while external controllers converged, so bothuseClusterand ordinary 300-second assertions failed early.Stall detection cannot infer external-system progress from an unchanged error string. It is now explicit opt-in.
Verification
tsc --noEmitbun test ts/: 251 passAll verification ran on monstera through the serialized test runner.