Repository navigation
fix(client): don't let non-JSON error bodies crash requests - #112
Merged
Merged
Conversation
FAMIS can return a 5xx with a plain-text body (e.g. "Service Unavailable" on a 503). Axios's default transformResponse could throw a raw SyntaxError trying to JSON.parse that body, which skipped throwResponseError entirely and surfaced an unhandled parse error instead of a clean ApiError with the real status. The shared axios instance now parses defensively and falls back to the raw string. Fixes #458 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alphahlee
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Service Unavailable"on a 503). Axios's defaulttransformResponsecould throw a rawSyntaxErrortrying toJSON.parsethat body, which skippedthrowResponseErrorentirely and surfaced an unhandled parse error instead of a cleanApiErrorwith the real status.throwResponseError/ApiErroralways get a real response to work with.CHANGELOG.md.Fixes apptreesoftware/facility360_r7#458
Test plan
"Service Unavailable"string body via a custom axios adapter — confirmed it now rejects withApiError(status 503) instead of a rawSyntaxError(test was removed afterward per request, since the fix is confirmed and covered manually)npm test— 11 suites / 113 tests passingtsc --noEmit— clean🤖 Generated with Claude Code