Repository navigation
fix: default missing required collections when filling response defaults - #2016
Merged
Merged
Conversation
The spec gives a model collection no default, and models only filled required fields that carry one, so a response that omitted a required collection left it undefined (JS) or failed to decode (every other SDK). An empty list is the one value a collection's type always admits, so required collections now fill with it; nested models stay absent.
2 tasks
🟢 Tier S · Ready to merge
Adds shared model-default handling so generated SDKs fill omitted required collection fields with empty arrays, while leaving optional fields and nested models absent. It adds an empty-presets mock plus generation and e2e coverage, and updates language templates and fixtures to support the behavior consistently. Latest changes: The Swift model template now reuses the escaped field name and emits
📂 Walkthrough · 9
Merged |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
Required collections give most list models a defaults entry, which surfaced three generator gaps: the JS services imported applyDefaults for upload methods that never call it, Swift wrote a trailing comma in a one-entry literal and a long decode fallback, and the Node service tests keyed their mock data with an escaped dollar sign.
…collections # Conflicts: # tests/e2e/languages/node/test.js # tests/e2e/languages/react-native/browser.js # tests/e2e/languages/web/index.html # tests/e2e/languages/web/node.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A required collection the spec gives no default stayed missing when a response omitted it.
Models only filled required fields that carry a spec default, and the spec never gives one to a collection.
Language::getModelDefault()now fills a required collection with[], the one value its type always admits. Every SDK that fills defaults reads it through the newmodelDefaultfilter. Optional fields stay absent. Nested models stay absent too, because an empty object may not satisfy the fields they require. Go is unchanged: a nil slice already reads as empty, and adding the defaultsUnmarshalJSONto every list model would decode each response twice.E2E: a new
listEmptyPresetsmock returns{"total": 0}and every SDK printsempty presets: 0.Now that list models carry defaults, three existing generator gaps showed up, and this PR fixes them too:
applyDefaultsfor upload methods that never call it. The import is now skipped for those methods.[].'\\$id', so the response never actually carried$id.Closes #2017