Repository navigation
fix(web): keep the JSON toString on responses filled with defaults - #2020
Merged
Merged
Conversation
Client.call defines a non-enumerable toString on every object response. fillDefaults rebuilds the object with a spread, which copies only enumerable own properties, so every response routed through applyDefaults printed [object Object]. Re-define the same toString on the filled result in the web, node and react-native templates.
🟢 Tier S · Ready to merge
The Web, Node, and React Native templates now preserve the JSON
📂 Walkthrough · 10
Reviewed |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client.callattaches a non-enumerabletoStringto object responses. The{ ...model.defaults, ...value }spread infillDefaultsdrops it, so every response that goes throughapplyDefaultsprints[object Object].Fix: when the input has its own
toString, the same one is defined again on the filled result. This covers the web, node and react-native templates. Deno has no such override.Test: the web, node and react-native e2e programs print
preset toString: ...(JS_MODEL_TO_STRING_RESPONSES).WebNodeTestfails without the template change ([object Object]) and passes with it.Node20TestandReactNativeTestpass.Related: #2017