Repository navigation
Fix PR #295 — Make Scenario Factory Valid, Restore Real Toolchain Builds, and Fix CI - #296
Conversation
…ation - Embedded canonical lockfile templates per (toolchain, packageManager) in .github/scripts/lockfile-templates.json. - Restored real framework build commands (astro build, vite build, vp build) and dependencies (astro, vite, vite-plus) in .github/scripts/generate-consumer-project.js. - Updated buildJsLockfile to populate valid, frozen-installable lockfiles with dynamic project name substitution. - Added test execution error diagnostics and handled binary lookup in __tests__/generate-consumer-project.test.ts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
…tegration - Embedded single-document lockfile templates for npm, pnpm, and Bun scenarios in .github/scripts/lockfile-templates.json. - Added allowBuilds configuration in pnpm-workspace.yaml for pnpm scenarios to fix ERR_PNPM_IGNORED_BUILDS. - Generated valid bun.lock fallback for Bun scenarios with and without framework toolchains. - Resolved pnpm and bun binary execution gracefully via npx fallback in __tests__/generate-consumer-project.test.ts.
…iggers - Added none:bun template and verified single-document lockfile templates in .github/scripts/lockfile-templates.json. - Updated getLockfileTemplates and buildJsLockfile in .github/scripts/generate-consumer-project.js to throw explicit actionable errors for missing template files, invalid JSON, or missing keys. - Added allowBuilds configuration in pnpm-workspace.yaml for pnpm scenarios to resolve ERR_PNPM_IGNORED_BUILDS. - Added real vp build integration test for pnpm Vite+ scenario and error boundary unit tests in __tests__/generate-consumer-project.test.ts. - Restricted pull_request event triggers to branches: ["main"] in .github/workflows/autofix.yml.
…tion - Removed branches: ["main"] restriction from pull_request event in .github/workflows/ci.yml and .github/workflows/test-actions.yml per user request. - Cleaned up buildJsLockfile in .github/scripts/generate-consumer-project.js to remove redundant fallback branches.
…low triggers - Ensured packageManager field is preserved for minimal Bun scenarios in .github/scripts/generate-consumer-project.js to prevent fallback to npm in resolveEnvironment. - Removed branches: ["main"] filter from pull_request triggers in .github/workflows/ci.yml and .github/workflows/test-actions.yml per user prompt instructions. - Increased integration test timeouts in __tests__/generate-consumer-project.test.ts for concurrent test suite stability.
…lue validation - Updated none:bun lockfile template in .github/scripts/lockfile-templates.json to a valid non-empty lockfile matching package.json devDependencies. - Strengthened getLockfileTemplates in .github/scripts/generate-consumer-project.js to strictly validate that every template key maps to a non-empty string. - Added comprehensive unit test cases in __tests__/generate-consumer-project.test.ts for empty template values and invalid value types (number, array, object). - Preserved workflow branch filters without modification.
Fixed Bun lockfile generation, restored real framework builds (Astro, Vite, Vite+), embedded valid lockfile templates, and improved test error diagnostics for PR #295.
PR created automatically by Jules for task 851987942805626893 started by @torn4dom4n