SpeakerKit: pass --diarizer instead of --engine to speakerkitpro-cli - #105
Merged
Merged
Conversation
speakerkitpro-cli `diarize` selects the backend with `--diarizer pyannote|sortformer`; the `--engine` flag openbench sent is rejected with "Unknown option '--engine'", so every `speakerkit*` evaluation against a current argmax-sdk-swift build failed on the first sample. Add unit tests for the generated CLI arguments. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
speakerkitpro-cli diarizeselects the diarization backend with--diarizer pyannote|sortformer. openbench'sSpeakerKitPipelineConfig.generate_cli_argsstill passed--engine, which a CLI built from currentargmax-sdk-swift@mainrejects:so every
speakerkit/speakerkit-sortformer-compressedevaluation failed on sample 0 (seen in argmaxinc/OpenBench-internal Argmax Diarization Benchmark run 35771963344 on a Mac Studio with Xcode 26.5).Switch the flag to
--diarizerand addtests/pipeline/test_speakerkit_cli_args.pycovering both backends,--model-path,--num-speakersand--api-key.whisperkitpro_engine.pyalready passes--diarizertowhisperkitpro-clisince #103; this PR brings the SpeakerKit pipeline in line with it.Test plan
uv run pytest tests/pipeline/test_speakerkit_cli_args.py(2 passed)uv run ruff check/ruff format --checkon the touched filesmain, from OpenBench-internal PR Add tests workflow #78 pinned to this branch🤖 Generated with Claude Code