Remove the MCP registration_log write (1.12.2) - #51
Merged
Merged
Conversation
Free signups were also appended to the EU AI Act MCP registration_log.jsonl, a file in another service's directory owned by another user. Its only reader was the retired funnel collector, and after the P5a switch the append would only fail with a warning. Signups still land in funnel_events.jsonl and conversion_events.jsonl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/v1/keys/free-signup(web form) and/api/register(MCP client) also appended each signup to the EU AI Act MCPdata/registration_log.jsonl, viaMCP_REGISTRATION_LOG. That file lives in another service's directory, owned by another user. Its only reader was the retired funnel collector, and once Trust Layer runs under its own user (P5a) the append would only fail with a warning. Decision: drop it._record_mcp_registration, its two calls andMCP_REGISTRATION_LOGremoved. Nothing else set the variable (unit, deploy script, infra).funnel_events.jsonlandconversion_events.jsonl. The MCP server keeps writing its own registration_log.main(no test covered the removed write).Not deployed on its own: it goes out with the P5a switch.
🤖 Generated with Claude Code