1.12.3: deploy without standby when declared, PROVE IT reference-run keys, smoke-secret rollback fix - #52
Merged
Conversation
Le jumeau local de PROVE IT (VM, D156 côté prove-it) n'a pas de VPS2. Le fichier d'état local porte "standby": "none" ; la phase 2a, les rollbacks et la lecture de topologie du standby sont alors sautés. Sans cette clé (VPS1 aujourd'hui), comportement inchangé. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…E IT (D153) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…etour arrière), plus le script en silence ; 1.12.3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
deploy_trust_layer_prod.shreads\"standby\": \"none\"from the local failover state and then skips phase 2a, the standby rollbacks and the standby topology read. VPS1 carries no such key: behaviour unchanged there. Roles are read from state, never inferred from a variable or a missing answer.provision_challenge_key.pygainsreference_soigneux,reference_presse,reference_sans_verification(internal plan, no email): one key and one DID per PROVE IT season reference run.SMOKE_INTERNAL_SECRET=$(grep … | cut …)exited the script underset -e, after the primary had restarted on the new code: no rollback, no tag, and callers believed the old code was still running. The reads now tolerate an empty result; the smoke test fails on it, which rolls back.How it was found and exercised
A local twin of PROVE IT (QEMU VM provisioned by the same Ansible roles as VPS1) ran this script end to end:
--closethen--openof a short season, all gates, phase 2b, smoke test PASSED, tag pushed; one run also exercised the automatic rollback. The twin surfaced the silent-death path.Checks
pytest tests: 920 passed.bash -n scripts/deploy_trust_layer_prod.sh.🤖 Generated with Claude Code