Repository navigation
test(heavy): drop the links RLS policy in the pre-v0.13 down-mutate fixture - #61
Merged
Merged
Conversation
v129's ks_source_isolation policy on links reads origin_page_id, so the pre-v0.13 fixture's DROP COLUMN origin_page_id fails with "other objects depend on it" and pg_upgrade_matrix aborts the whole Heavy Tests run. A pre-v0.13 brain never had the policy; the walk-forward re-creates it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GCX2qPfuXzjf2QBmBDjbJY
Author
|
Two red unit shards. Neither is caused by this PR, which only changes
I'm keeping both fixes out of this PR so it stays scoped to the Heavy Tests fixture. I tried to re-run the failed jobs, but this integration doesn't have permission (403), so a maintainer would need to use "Re-run failed jobs". Generated by Claude Code |
rosseyre
marked this pull request as ready for review
October 22, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Heavy Tests on master fail at
tests/heavy/pg_upgrade_matrix.sh. Building thepre-v0.13fixture fails with:Migration v129 (#53, per-artifact access labels) changed the
linksRLS policy so it readsorigin_page_id. As a result, the down-mutate'sALTER TABLE links DROP COLUMN origin_page_idcan't run.run-heavy.shstops at the first failing script, so the three scripts after the matrix haven't run in CI since then either.Fix: the pre-v0.13 down-mutate now drops
ks_source_isolation ON linksbefore it drops the column. A real pre-v0.13 brain never had this policy, so the fixture is now more accurate. The walk-forward (v11 → v129) adds the column back first and then re-creates the policy. This PR changes the fixture only; no product code changes.Test plan
Run locally against Postgres 16 + pgvector with Bun 1.3.13:
_build_legacy_fixtures.sh pre-v0.13exits 3)bash tests/heavy/pg_upgrade_matrix.sh: both shapes walk forward cleanlylinkspolicy exists again and still has itsorigin_page_idclausebun run test:heavy: all 6 scripts pass, including the 3 that had been hidden behind the matrix failureGenerated by Claude Code