Skip to content

docs: embed light/dark styling in svg diagram - #389

Merged
awphi merged 1 commit into
mainfrom
embed-styling-in-svg
Aug 3, 2026
Merged

docs: embed light/dark styling in svg diagram#389
awphi merged 1 commit into
mainfrom
embed-styling-in-svg

Conversation

@awphi

@awphi awphi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Changes

  • The troublesome diagram SVG strikes again and has bricked staging deployment! The problem is that APDS wants the index page to be a standalone React app and does not support relative imports. Here's what's been tried so far:
    • Relative @site imports - works for publishing, does not work for previewing locally
    • Symlinking the svg into the index page dir - works for previewing locally, does not work for publishing
    • This; embedding the light/dark styling in the svg itself (the whole reason we want to inline the svg at all) and just using an <img> tag in the public directory - seems to work for both.
  • Also softens the foreground color in light mode to match the new text styling

Successful staging deploy from this branch: https://github.com/arm/topo/actions/runs/30658690136

Checklist

  • 🤖 This change is covered by tests as required.
  • 🤹 All required manual testing has been performed.
  • 📖 All documentation updates are complete.

Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
@awphi
awphi requested a review from a team as a code owner July 31, 2026 19:23

@yejseo01 yejseo01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would it be okay to attach the difference in screenshots from now on?

@awphi

awphi commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

LGTM. Would it be okay to attach the difference in screenshots from now on?

Sure, have just been avoiding it since the docs are still unreleased! Probably doesn't matter in all honesty though.

@awphi
awphi merged commit dcb72d1 into main Aug 3, 2026
8 checks passed
@awphi
awphi deleted the embed-styling-in-svg branch August 3, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants