Conversation
Historie transakcí only supported browsing by date-sorted pages, with no way to narrow down the large transaction list (issue arnost00#55). Add filters for date range, member, amount range, note text and claims, and replace the existing year-only grouping with per-month grouping (still nested by year via the label) so the default view stays small.
Nespárované bankovní platby only filtered by date range, making it hard to check whether one specific unmatched payment is present. Add filters for variable symbol, amount range and originator message, the fields an accountant actually has on hand from a bank statement.
- add reusable parameterized SQL filter and time-range abstractions - load transaction history by month on demand through an authenticated endpoint - retain loaded month rows locally while supporting collapse and retry - refactor unmatched bank-payment filtering to prepared statements - distinguish database errors from valid empty results - share lazy month/year range-heading rendering in a base detector - add the finance storno/date index migration and update the version - add Playwright coverage for filtering, lazy loading, and endpoint access This functionality shall later apply on races table as well,
Collaborator
|
Změřil jsem časy na zbm databázi. Pro stránkování po 50 je na otevření první stránky potřeba jedna query 40ms. Pro posledni stránku 540ms. Pro lazy loading je potřeba 37ms na seznam měsíců a 18ms na první měsíc. Dohromady 55ms. Každý další měsic 18ms i když je z roku 2017. |
- use data-group consistently for month and year grouping - switch month expansion to the shared group toggle - remove the obsolete class-based toggle helper - preserve authoritative range visibility attributes during row-attribute merges - update finance-history tests for the unified grouping contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co a proč
Řeší #55 — Historie transakcí zatím šla jen procházet po stránkách řazených podle data, bez možnosti záznamy zúžit. Při větším množství transakcí je pak těžké najít konkrétní platbu.
Historie transakcí
Nespárované bankovní platby
Jak to bylo otestováno
Obě stránky prošly manuálně přes lokální dev docker-compose (přihlášení jako
admin), pro každý filtr zvlášť ověřeno, že vrací jen odpovídající záznamy (u nespárovaných plateb dočasně vloženy testovací řádky, po ověření smazány).php -lbez chyb na všech upravených souborech.