Repository navigation
cuda norms: nGPT rows, L2 norms with eps on the sum and the normalized lerp residual (Dory, #1233) - #1256
Closed
jschmied wants to merge 2 commits into
Closed
cuda norms: nGPT rows, L2 norms with eps on the sum and the normalized lerp residual (Dory, #1233)#1256jschmied wants to merge 2 commits into
jschmied wants to merge 2 commits into
Conversation
…d lerp residual Dory's residual stream lives on the unit sphere, so its rows need two kernels norms.cu did not have, both a block a row (256 threads, 16-byte loads, rows to 8,192 in 64s), so a row's bits never depend on the row count: - tf_l2_rows: y = bf16(s / sqrt(sum(s^2) + eps)), s = x, or bf16(x + r) (a loop's entry, justnorm(state + input_h); with r null, a loop's exit). - tf_slerp_rows: dory.py's slerp_norm, h = bf16(l2(a + |alpha scale| (b - a))) with a = bf16(l2(res)) and b = bf16(l2(out)), the lerp in fp32 steps. Norms.l2 and Norms.slerp launch them; no existing kernel or launch changes. Both are registered with the kernel contract. Their check compares every output with float64's value at the bf16 rounding points as a range over the fp32 run's spread (core/l2_ref.zig); three controls each drop one rounding point (the sum before the norm, the slerp's a, its b) and go red at gate 3. Gate 4's integer rows make an fp16 sum overflow to a zero output (85x and 51x the bound); a bf16 sum's scale cancels in the norm, so that margin is stated, not proven, as for the RMS tails. Launch records from nvcc 13.0's sm_80/86/89/120/121 images.
This was referenced Oct 24, 2026
7 of 9 tasks
Owner
|
Landed on main in 6528fbe..81b476d: the whole Dory stack (#1256-#1261), with your records under your authorship plus five maintainer children. The children refuse host-only formats and refund failed upload ownership, pin release launch arguments, keep the unmeasured Dory launches pending in the contract, and own queued host inputs through stream completion. Every existing family file, contract entry and recorded launch is byte-identical. Thank you, Jürgen. On a GB10 with nvidia/NVIDIA-Nemotron-Labs-Dory1.0-4B-NVFP4 @ 41f02335, served at 2 loops with CUDA graphs:
- Synthema, Ash's AI Assistant. |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Step 3, first kernel PR of the Dory family (#1233). Dory's residual stream lives on the unit sphere, so its rows need two kernels
norms.cudoes not have. Both are a block a row (256 threads, 16-byte loads, rows to 8,192 in 64s), so a row's bits never depend on the row count. No existing kernel or launch changes.This PR closes nothing. The issue is #1233, and the family stays open there.
Stacking. The base commit of this branch is the contract include fix from #1245 (
cuda contract: the softcap control includes the act_round helpers it calls). Without itcontract_controls.cudoes not build onmain. It is the same patch as #1245. Drop that one commit when either lands. After it comes one commit, the norms.Stack: PR1 (this) <- #1257 qk_rows <- #1258 act_rows <- #1259 dense_rows <- #1260 family <- #1261 serving.
What the kernels compute
tf_l2_rows:y = bf16(s / sqrt(sum(s^2) + eps)), eps = 1e-6 on the sum (not on the mean), fp32 sum, IEEEsqrtand division.s = x, ors = bf16(x + r)(a loop's entry,justnorm(state + input_h); withrnull it is a loop's exit).tf_slerp_rows: dory.py'sslerp_norm.a = bf16(l2(res)),b = bf16(l2(out)),z = a + lr * (b - a)in fp32 steps withlr = |alpha * (alpha_init / std)|a host-formed fp32 vector,h = bf16(l2(z)).Norms.l2andNorms.slerplaunch them.Rounding points (the choice in #1233 question 3, open): a tensor that dory.py holds as bf16 is rounded to bf16, and all arithmetic between those points is fp32. Here:
bf16(x + r), the output of each l2,a,bandh. The lerp is not rounded between its steps.Kernel contract
Both are registered with the kernel contract. The check compares every output with float64's value at the bf16 rounding points, as a range over the fp32 run's spread (
core/l2_ref.zig).a, the slerp'sb.tf_l2_rows: 48/48/48/64/64 regstf_slerp_rows: 113 regs on all fivemain.Receipt
d2a0e1b22on top oforigin/main6244c6206; NVIDIA GB10 (sm_121), CUDA 13.0 nvcc, Zig 0.17.0.zig build test -Dnvcc=...: exit 0 at this branch head (zig build test -Dnvcc=/usr/local/cuda/bin/nvcc, the full step).main.mainplus the include fix,SUMMARY 280 kernels: 278 pass gates 1-4, 2 fail, 2 known findings; 53 controls: 52 red as planted, 1 missed; 1566 limit problems. On this stack's top:SUMMARY 290 kernels: 288 pass gates 1-4, 2 fail, 2 known; 62 controls: 61 red, 1 missed; 1566 limit problems. That is 10 Dory kernels and 9 Dory controls added, all passing or red; the 2 failures, the 1 missed control and the 1,566 limit problems are the same onmain(qwen35 decode attention,tf_q35_gdn_slotsrecords of 0). Two things onmainkeep the unmodified run from completing:w4a8_tests.zigdoes not compile againstw4a8.zig'spromptsignature, and the w4a8 kernels lose the CUDA context on their planted non-finite inputs. Both runs above skipped the w4a8 kernels and patched that test call locally, identically on both trees; neither patch is in this PR. All Dory launches pass the live limits check.Choices ashhart can change
The open questions of #1233 are not answered there yet. This stack follows the defaults below, and each is easy to change:
per_looponly; not relevant to this PR.--loopsas a load option; not relevant to this PR.