Repository navigation
server: accept dialogue speaker tags (depends on #1277) - #1278
Closed
krunkosaurus wants to merge 4 commits into
Closed
krunkosaurus wants to merge 4 commits into
krunkosaurus wants to merge 4 commits into
Conversation
9 tasks done
ashhart
added a commit
that referenced
this pull request
Oct 26, 2026
Owner
|
Landed on main in 715a074 on top of #1277, thanks @krunkosaurus. Untagged and |
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Depends on #1277; merge sampling first. Incremental source review: 56648b94...60eb5d21. The final merge commit resolves the two feature documentation entries and test-module imports, retaining both native implementations unchanged.
Native Drama HTTP requests and reference transcripts accept canonical
<|speaker:0|>through<|speaker:15|>tags. Existing prompt construction already represents these roles; this removes the server's speaker-zero-only refusal while preserving malformed-tag/structural-token validation. Fixes #1274.Untagged input still starts as speaker 0, and modern catalogs still allow at most four reference passages. Sixteen role tokens do not promise sixteen cloned voices. Reference speaker changes invalidate the existing exact-prefix cache; request-only speaker changes can reuse an identical reference prefix.
The Sogni-AI/drama3-mlx prompt tests are a behavioral reference. This independently extends TensorFold's native validation and existing builder; no Fish-derived Python implementation is copied.
Receipt
Base
2ff01910; Zig 0.17.0, macOS arm64. Tests use synthetic integer codes and scripted PCM.zig build test-server-cpu test-drama-host -j4: 777/780 passed, 3 skipped, 9/9 build steps. Standalone Drama host confirmation: 39/39 passed.60eb5d21:zig build test-server-cpu test-drama-host -j2 --summary allpasses 784/787 tests, three skipped, 9/9 steps. Independent agent review confirms every nonconflicting source file matches its reviewed parent and both test imports are retained.Repository-wide checks on speaker commit
945c797breached 499/502 build steps and 5,862/5,897 passed tests, 34 skipped and one crash: unchangedtest-pull-hostaborts with macOS ISCONN. The untouched base reproduces 20/21 passed and one crash. Plainzig buildreached 223/226 steps with one compilation failure: unchangedtf-flashnext-runassigns SharedEvent to Event; the untouched base reproduces it (50/53 steps). These are recorded failures, not passing whole-upstream receipts.Draft qualification limit: no device/model inference, voice-similarity listening, audio identity or performance qualification. Available memory is below the recipe launcher's admission floor; that guard was not overridden. Tags preserve model roles, not a guaranteed acoustic identity.
During final CPU replays, two unchanged recall tests failed while the volume had about 3.3 GiB free, below their existing 4 GiB admission floor. Removing only task-created compiler caches restored 5.043 GiB; the identical commands passed with no source, environment or admission-guard change. Original failure receipts were retained.
Integration
ATC issue/session coordination and independent review completed. #1268 merges cleanly in production code, with README/CHANGELOG conflicts. Complete inspection of oversized #728 adds no conflict paths beyond its 163 baseline conflicts. The separate legacy source/recipe companion is explicitly stacked after protected chunking, because arbitrary hard cuts otherwise fragment speaker markers.
Pinned-engine packaging and user documentation: drama-tensorfold companion PR.