Repository navigation
tools: cuda_sass_identity.py rebuilds a differing image and fails on an unstable build - #1532
Merged
Merged
Conversation
jschmied
force-pushed
the
sass-recheck
branch
from
October 28, 2026 17:36
0d003da to
5edec0f
Compare
jschmied
marked this pull request as ready for review
October 28, 2026 17:37
…an unstable build A function counts as changed only if base and head differ again in a rebuild, one build at a time; a tree whose two builds disagree is reported as unstable and the exit status is non-zero. --no-recheck keeps the first builds' count.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1440, as asked there. One commit, now rebased onto main after #1440's merge.
What
When an image differs between base and head, the tool builds it again from both trees, one build at a time:
--no-recheckkeeps the old behaviour: the first builds' differences count, without a rebuild.The logic sits in one function,
recheck(), and the main loop only builds and prints.Checks
python3 -m unittest cuda_sass_identity_test(fromtools/zig): 6 tests pass. The 3 new ones use canned dumps:b30d5b9d3→1e627ed14, nvcc 13.0):nvfp4_expertshas 5 functions changed (tf_nvfp4_fact_swigluon 5 SMs);-Xptxas -O1. Result: 65 functions unstable, exit 1.lean_check: 0 new.zig build test: passes.