Repository navigation
Windows: the cost cache reads tables through shared handles, so a pending delete is a quiet miss - #1809
Merged
Conversation
ashhart
force-pushed
the
lead/windows-cost-cache
branch
from
November 1, 2026 10:07
b0bf9b3 to
251d8c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S150 (scodex): on Windows,
cost_cache.loadAtopens a table while a writer replaces it; Windows returns NTSTATUS 0xc0000123 (FILE_DELETED), the standard library logs it as unexpected, and the test runner fails a test that logs an error, thoughloadAtreturns a miss as designed (seen on a CI run for #1797).cost_cache_windows_test.zig; non-Windows loading, the parser, the publisher and the original strict concurrent test are unchanged.Fixes #1805.
🤖 Generated with Claude Code