watch: accept math-proof:siege (detector false positive, #240) - #241
Merged
Merged
Conversation
sprayberry-redline
approved these changes
Oct 1, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. The acceptance is scoped to the recorded SKILL.md hash, and its rationale explains how the detector crosses a clause boundary. The existing remainder scan keeps changed bytes and findings in other files subject to detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triage of #240 (math-proof:siege). Verdict: benign, detector false positive. Same clause-spanning class as #220 / askalf/redstamp#170.
What I read
./plugins/math-proof, fetched at anthropics/claude-plugins-official@ab024cd.skills/siege/SKILL.mdsha256f40134d3…6b542, byte-identical to the watch triage: math-proof:siege — flagged, awaiting review #240 snapshot.SKILL.md:612is in the wave-planning brief: at most two queries may go to "routes the main line does not descend from (set aside, not refuted, under summary rule (ii))". "set aside, not refuted" is the skill's own term for an obstructed route that was not refuted, defined in summary rule (ii) at :515-518. "summary rule" is a cross-reference to that rule. Nothing is being overridden.scripts/ledger.pyimports only re/sys/pathlib.Why it still fires
truecopy pins
@askalf/redstampv0.7.5, where the gap is[^.]{0,40}. redstamp v0.8.0 (#181, closing #170) changed it to[^.,;:|]{0,40}, and with that regex this line no longer matches (checked locally). So no new redstamp issue is needed. Moving truecopy's pin to v0.8.0 should keep this class from re-flagging.Verification
npm ci+node support/watch-accept.mjs <skill-dir> --filesattributes the single finding to SKILL.md and the remainder scans clean. The emitted hash matches the snapshot.Closes nothing by hand: per the issue, recording the acceptance auto-closes #240 on the next watch run. Source ticket: WT-86cdee52.