Repository navigation
Conversation
…late credentials ## Motivation This PR ensures that credentialed HTTP requests in `surf-cli` correctly bypass the local disk response cache, preventing private responses from being improperly shared or leaked across distinct user credentials or local profiles[cite: 44, 45, 46]. ## Modifications * **Credential-Aware Transport Routing (`cli/transport.go`)**: * Implemented `credentialAwareTransport` to check outbound requests for `Authorization`, `Proxy-Authorization`, or `Cookie` headers[cite: 45]. * Automatically routes requests carrying session/auth credentials directly through the uncached default transport while maintaining standard caching behavior for anonymous requests[cite: 45]. * **Regression Testing (`cli/transport_test.go`)**: * Added `TestCachedTransportDoesNotShareCredentialedResponses` to verify that consecutive requests with differing bearer tokens hit the origin server independently rather than returning a cached response[cite: 46]. ## Checklist - [x] Format your code according to the Contributor Guide. - [x] Add unit tests as outlined in the Contributor Guide. - [x] Update documentation as needed, including docstrings or example tutorials. ```[cite: 44, 45, 46]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR ensures that credentialed HTTP requests in
surf-clicorrectly bypass the local disk response cache, preventing private responses from being improperly shared or leaked across distinct user credentials or local profiles[cite: 44, 45, 46].Modifications
cli/transport.go):credentialAwareTransportto check outbound requests forAuthorization,Proxy-Authorization, orCookieheaders[cite: 45].cli/transport_test.go):TestCachedTransportDoesNotShareCredentialedResponsesto verify that consecutive requests with differing bearer tokens hit the origin server independently rather than returning a cached response[cite: 46].Checklist