Skip to content

Optimize table formatting hot paths #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodingFeng101 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Optimize table formatting hot paths #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tabulate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ def _isnumber_with_thousands_separator(string):
except (UnicodeDecodeError, AttributeError):
pass

return bool(re.match(_float_with_thousands_separators, string))
return bool(_float_with_thousands_separators.match(string))


def _isconvertible(conv, string):
Expand Down Expand Up @@ -1220,7 +1220,7 @@ def _align_column(
width_fn = _align_column_choose_width_fn(has_invisible, enable_widechars, is_multiline)

s_widths = list(map(width_fn, strings))
maxwidth = max(max(_flat_list(s_widths)), minwidth)
maxwidth = max(max(_flat_list(s_widths) if is_multiline else s_widths), minwidth)
# TODO: refactor column alignment in single-line and multiline modes
if is_multiline:
if not enable_widechars and not has_invisible:
Expand Down