Accept tuples for rowalign and other sequence arguments#436
Open
uttam12331 wants to merge 1 commit into
Open
Conversation
tabulate(..., rowalign=('top', 'bottom')) raised
'TypeError: can only concatenate tuple (not "list") to tuple' because
_expand_iterable() concatenated the padding list directly onto the original
iterable. Coerce the iterable to a list first, so non-list sequences (e.g. a
tuple passed as rowalign or maxcolwidths) work the same as lists.
Closes astanin#434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #434.
tabulate(..., rowalign=('top', 'bottom'))raised:_expand_iterable()concatenated its padding list directly onto theoriginaliterable (original + [default] * n). Whenoriginalis a tuple — as a user can reasonably pass forrowalign(andmaxcolwidths/maxheadercolwidths) —tuple + listfails, even when no padding is needed.Fix
Coerce
originalto alistbefore concatenating, so any non-list sequence behaves the same as a list:Tests
Added
test_rowalign_tupletotest/test_regression.pyasserting the tuple form produces the same output as the list form.Verified locally: full suite
pytest test/→ 366 passed, 1 skipped.