Skip to content

chore(renovate): disable engines updates and remove automerge - #679

Merged
jim-counter merged 1 commit into
mainfrom
chore/renovate-config-cleanup
Jul 3, 2026
Merged

chore(renovate): disable engines updates and remove automerge#679
jim-counter merged 1 commit into
mainfrom
chore/renovate-config-cleanup

Conversation

@jim-counter

@jim-counter jim-counter commented Jul 3, 2026

Copy link
Copy Markdown
Member

What

Two changes to .github/renovate.json:

  1. Disable engines-field updates. Renovate kept proposing patch-level engine floors (chore(deps): update node.js to >=22.23.1 #674 wanted node >=22.23.1), and would re-file after every Node patch release. A patch-level floor blocks downstream consumers — Yarn Berry enforces dependency engines strictly — while guaranteeing nothing, since no code depends on Node patch versions. Engine floors are a support-policy decision for humans. Workflow node-version updates (github-actions manager) are unaffected and continue as before (like chore(deps): update node.js to v24 #670).

  2. Remove automerge entirely. The existing rule was broken — matchDepTypes: ["minor", "patch", "devDependencies"] mixes update types into a dep-type matcher, so it silently made all devDependency updates automerge-eligible, majors included. In practice it never fired because branch protection requires an approving review, which Renovate can't provide. Rather than fix the rule, remove it: given the recent npm supply-chain attacks, dependency merges should stay a deliberate human action. minimumReleaseAge (3 days, 7 for majors) remains as the quarantine against compromised releases.

🤖 Generated with Claude Code

@jim-counter
jim-counter force-pushed the chore/renovate-config-cleanup branch from 49fd740 to 7def1de Compare July 3, 2026 10:10
@jim-counter jim-counter changed the title chore(renovate): disable engines updates and fix automerge rule chore(renovate): disable engines updates and remove automerge Jul 3, 2026
@jim-counter
jim-counter requested a review from EmilFattakhov July 3, 2026 10:14
- Disable engines-field updates: Renovate kept proposing patch-level
  floors (e.g. node >=22.23.1, PR #674) that block downstream Yarn
  Berry consumers without any real compatibility guarantee. Support
  floors are a human decision.
- Remove the automerge rule entirely. It was broken anyway
  (matchDepTypes with "minor"/"patch", which are update types, so it
  silently covered all devDependencies updates including majors), and
  branch protection's required review meant it could never fire. Given
  npm supply-chain risk, dependency merges stay a deliberate human
  action; minimumReleaseAge (3/7 days) remains the quarantine.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jim-counter
jim-counter force-pushed the chore/renovate-config-cleanup branch from 7def1de to cbfe837 Compare July 3, 2026 14:26
@jim-counter
jim-counter merged commit 942b211 into main Jul 3, 2026
3 checks passed
@jim-counter
jim-counter deleted the chore/renovate-config-cleanup branch July 3, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants