Repository navigation
Conversation
…ect researcher credit Signed-off-by: chaksaray <chaksaray@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339.
Both records cited only the cfgaudit crosswalk gap and their own registry entry, which does not meet CONTRIBUTING.md's primary-source rule. Both also credited the maintainer and bawbel.io, against researcher-process.md.
researcherbecomes "Check Point Research (Aviv Donenfeld, Oded Vanunu)", andresearcher_urlbecomes the report.researcherbecomes "hackerone.com/cantina_xyz", andresearcher_urlis removed.last_updatedis bumped, and oneaivss.notessentence per record states the sources and the caveat.Not changed: scores, mappings, fingerprints,
mutation_count,published.Left for separate issues: the corpus-wide researcher pattern (57 of 87 records credit the maintainer, 58 use bawbel.io), and the
owasp_asi,mitre_atlasandnist_ai_rmfkeys, which are absent (not null) on both records.Sources read, with credit lines as written
The existing cfgaudit reference (#67) still resolves and is kept.
Where this differs from the plan in the original task brief
The brief was drafted from secondary coverage. Reading the primary sources changed four things:
hackerone.com/avivdon, not "Check Point Research". Check Point's own report supports crediting Check Point Research: it is by Aviv Donenfeld and Oded Vanunu, and its timeline says "Check Point Research reported" both findings. Soresearchernames the organization and both authors from the first-party report. I do not assert that the HackerOne handle is Aviv Donenfeld.researcher_urlfor 00063.hackerone.com/cantina_xyzreturns 404, and I found no first-party Cantina write-up.researchertherefore uses the credit exactly as the advisory gives it, andresearcher_urlis omitted, as researcher-process.md allows. The handle likely belongs to Cantina (cantina.xyz), but nothing first-party says so. Your call whether to name the firm.Verified
validate_records.pypasses (87 valid; no maintainer-name warning for either record now) andpytest519 passed.check_fixtures.py,check_framework_sources.py --strict --only(both records),check_mutation_thm_trail.py --strict --only(both records) and the confidence ratchet (2 records changed, passes) all pass.json.loads(after)equals the same changes applied tojson.loads(before), and that the key order is unchanged. The diff is a handful of lines per record.dist/was rebuilt byscripts/build-records.jsand equalsrecords/for all 87 records. The dist diff touches only the 00063 and 00064 entries and the manifest timestamp.Could not verify
hackerone.com/avivdonandhackerone.com/cantina_xyzare the people or firms the names suggest. Neither advisory says.🤖 Generated with Claude Code