Fix uniquename bug - #333
Open
parrangoiz wants to merge 4 commits into
Open
parrangoiz wants to merge 4 commits into
parrangoiz wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gpeairs
reviewed
Sep 30, 2026
gpeairs
left a comment
gpeairs
left a comment
Member
There was a problem hiding this comment.
Thanks, just one more case I'd like to cover below.
…ses base_id literally
uniquename("x_3_1", '_') returned "x3_1" because the base name was rebuilt with
join(substrings[1:end-1]) without the delimiter, and any trailing integer was read as an
occurrence counter, so schematic nodes (add_node! → node ids → locator prefixes and cell
names) for components named like lattice sites (s_3_1, a_2_1) were mangled/renumbered.
- join with dlm; a bare number is not a suffix
- new keyword parse_suffix (default true keeps the documented str0$n behavior); add_node!
passes parse_suffix=false so base_id is used as the node id unless already taken, as its
docstring says
- tests for uniquename and node ids; CHANGELOG
From @gpeairs PR comment Co-authored-by: Greg Peairs <gpeairs@amazon.com>
parrangoiz
force-pushed
the
arrangop/uniquename-bug-fix
branch
from
September 30, 2026 17:46
9ffdc00 to
767c590
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #332