Conversation
e1b395b to
9fa1e4a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Given that |
|
UPD: It's |
|
I suggest sending "global" to the new key in the constructor ( I also have a mild preference for |
A parameter file written against the released `global:` spelling used to load without error but leave `globals` empty, so every shared parameter silently vanished. Migrate the key in the root constructor instead and warn once.
Renames the required top-level
ParameterSetnamespaceglobaltoglobals(ps.globals.version,globals:in YAML).REQUIRED_NAMESPACES, docstrings, and docstring examples insrc/schematics/parameter_set.jltest/test_parameter_set.jldocs/src/tutorials/parameter_set.mdIt's a breaking, as
ParameterSetshipped in 1.18.0. Existing YAML files/dicts usingglobal:load without error but leaveglobalsempty, so old PS serializations must rename the key.Testing
ParameterSet test items pass locally (353/353).