fix: handle initial and dtype in reductions - #74
Open
Robertboy18 wants to merge 1 commit into
Open
Conversation
Robertboy18
force-pushed
the
fix/reduction-initial-dtype
branch
from
July 31, 2026 22:13
fd3d5ed to
fdbb3cc
Compare
Contributor
|
neuronx-cc currently doesn't support init value in reduce op, opened a ticket to compiler team NCC-9303. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dtypeis specifiedinitialvalue instead of always using the identitysum,prod,max, andmininitial values and explicit reduction dtypesProblem
The HLO reduction helper accepted
initialanddtypebut ignored both. As a result,np.sum(x, initial=10)still initialized the reduction with zero, andnp.sum(x, dtype=np.float16)still returnedfloat32. The resulting HLO compiled successfully but had different semantics from NumPy.Testing
pytest -q tests/unit/test_tensor_api.py -k "reduction or prod"(30 passed)trn2with NeuronX Compiler 2.26I did not have Trainium hardware available, so validation covered HLO semantics and compilation rather than device execution.