-
Notifications
You must be signed in to change notification settings - Fork 92
feat(project): show create progress like build and deploy #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e8e14a6
feat(project): run create under the shared step-progress driver
aidandaly24 38c12b1
feat(project): tail subprocess output under create's running step
aidandaly24 97b155c
test(project): use the renamed agent-python shortcut constant
aidandaly24 06961a7
feat(project): show package names while npm installs
aidandaly24 83c4dce
refactor(project): inline npm progress rendering and drop its plumbin…
aidandaly24 510c9b5
refactor(project): remove npmProgress.ts, now inlined in manager
aidandaly24 646fb74
refactor(project): make run stream instead of adding a second method
aidandaly24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import z from "zod"; | ||
| import { createHandler, flag } from "../../../router"; | ||
| import { SourceResolver, type AppIO } from "../../../io"; | ||
| import { runWithProgress } from "../../../tui/progress"; | ||
| import { | ||
| LANGUAGE_VERSION_DEFAULTS, | ||
| MEMORY_SHORTCUT_NAMES, | ||
|
|
@@ -28,7 +29,7 @@ import { DEFAULT_HARNESS_MODEL } from "../add/harness"; | |
| import type { CoreBedrockAgentImporter } from "../../../core/project/bedrockAgentImport"; | ||
| import { importScaffoldRuntimeInput, resolveImportBedrockAgentInput } from "../importBedrockAgent"; | ||
| import type { ImportBedrockAgentInput } from "../add/runtime/types"; | ||
| import { RegionKey } from "../../keys"; | ||
| import { JsonKey, RegionKey } from "../../keys"; | ||
|
|
||
| type CreateProjectHandlerConfig = { | ||
| projectManager: ProjectManager; | ||
|
|
@@ -300,9 +301,12 @@ export const createCreateProjectHandler = (config: CreateProjectHandlerConfig) = | |
| ); | ||
| } | ||
|
|
||
| for await (const event of config.projectManager.create(createInput)) { | ||
| if (event.type === "step") config.io.stderr.write(`${event.message}\n`); | ||
| } | ||
| // Same driver as build and deploy: a live step list in a TTY, and the previous plain | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: i don't feel like this comment is relevant. |
||
| // line-per-step output when stderr is not a TTY or --json wants no ANSI on it. | ||
| await runWithProgress(config.projectManager.create(createInput), { | ||
| io: config.io, | ||
| interactive: ctx.require(JsonKey) ? false : undefined, | ||
| }); | ||
|
|
||
| config.io.stderr.write(`Created project '${name}' in ./${name}\n`); | ||
| config.io.stderr.write(`To deploy it: cd ${name} && agentcore project deploy\n`); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOS here since I think its existing behavior, but this is dumping raw output (with ANSI codes) into the logs which are not human readable.
Ex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhhh this is a good call out. I can fix this in a follow up. I don't think that this was pre existing.