feat(templates): support agui for python - #2185
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2185 +/- ##
=========================================
Coverage 97.12% 97.12%
=========================================
Files 535 535
Lines 36844 36889 +45
=========================================
+ Hits 35783 35828 +45
Misses 1061 1061 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Changes requested
Nice, tight scaffold that closely mirrors a2a-python-strands. One concern worth resolving before merge:
ag-ui-strands version pin is incompatible with the shortcut's Python runtime
src/assets/templates/agui-python-strands/pyproject.toml pins ag-ui-strands >= 0.1.7, < 0.2.0, but every release in that range publishes Requires-Python: <3.14,>=3.12. The agui-python-strands shortcut in src/handlers/project/shortcuts.ts sets runtimeVersion: "PYTHON_3_14", which the CodeZip packager in agentcore-l3-cdk-constructs/src/lib/packaging/python.ts forwards to uv pip install --python-version 3.14. pip refuses to resolve this combination outright:
$ pip download 'ag-ui-strands>=0.1.7,<0.2.0' --python-version 3.14 --only-binary :all:
ERROR: Could not find a version that satisfies the requirement ag-ui-strands<0.2.0,>=0.1.7
(from versions: 0.2.5, 0.3.0)
uv happens to be lenient enough to pull down 0.1.9 today, but relying on that is fragile: the package author has explicitly declared their code doesn't support 3.14, and any tightening of uv's requires-python enforcement will break the default agentcore project deploy for anyone scaffolding this template. (ag-ui-protocol and the container path via python:3.12-slim-trixie are both fine — this is unique to the ag-ui-strands pin.)
Two ways to fix:
- Bump the pin to a range that includes 3.14-compatible releases, e.g.
ag-ui-strands >= 0.2.5, < 0.4.0(0.2.5 and 0.3.0 both declare<3.15,>=3.10). - Change the shortcut's
runtimeVersiontoPYTHON_3_13so the pin stays inside the package's declared support window.
Everything else looks good: the resolver mirrors the a2a resolver's structure, the AGUI protocol is already wired through dev port/inspector/schema, tests use real temp dirs, and there's no telemetry surface that needs updating for a new template preset.
|
Claude Security Review: no high-confidence findings. (run) |
Problem
AGUI Python templates are not supported.
Solution
Verification
had my agent verify the same flow for container, memory/no-memory, and with gemini.