fix: address double function implementation failing tsc - #2192
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Trivial and correct typecheck fix. The pre-PR fakeBackend in src/handlers/project/buildDeploy.screen.test.tsx declared resolveProjectResources twice (lines 59–61 and again at 65–67), causing TS2300: Duplicate identifier. Removing the second copy leaves one resolveProjectResources and one resolveDeployedResources, which matches the ProjectBackend interface. Nothing else to flag — no telemetry/mocking implications for a test-only dedup. Good to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2192 +/- ##
=========================================
Coverage 97.15% 97.15%
=========================================
Files 542 542
Lines 37728 37728
=========================================
Hits 36653 36653
Misses 1075 1075 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the report, @codecov-commenter — feedback like this is exactly Would you mind opening a new issue so we can track it properly? If this is a security issue, please report it privately via |
Problem
The tsc is failing (again)
https://github.com/aws/agentcore-cli/actions/runs/33790922020/job/100784295618
Solution
remove the duplicates
Verification
bun run typecheck