Skip to content

fix: address double function implementation failing tsc - #2192

Merged
nborges-aws merged 1 commit into
aws:refactorfrom
Hweinstock:fix/tsc-2
Sep 3, 2026
Merged

fix: address double function implementation failing tsc#2192
nborges-aws merged 1 commit into
aws:refactorfrom
Hweinstock:fix/tsc-2

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

The tsc is failing (again)

$ tsc --noEmit
src/handlers/project/buildDeploy.screen.test.tsx:65:11 - error TS2300: Duplicate identifier 'resolveProjectResources'.

65     async resolveProjectResources() {
             ~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in src/handlers/project/buildDeploy.screen.test.tsx:65



https://github.com/aws/agentcore-cli/actions/runs/33790922020/job/100784295618

Solution

remove the duplicates

Verification

bun run typecheck

@github-actions github-actions Bot added the size/xs PR size: XS label Sep 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 3, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Sep 3, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Trivial and correct typecheck fix. The pre-PR fakeBackend in src/handlers/project/buildDeploy.screen.test.tsx declared resolveProjectResources twice (lines 59–61 and again at 65–67), causing TS2300: Duplicate identifier. Removing the second copy leaves one resolveProjectResources and one resolveDeployedResources, which matches the ProjectBackend interface. Nothing else to flag — no telemetry/mocking implications for a test-only dedup. Good to merge.

@Hweinstock
Hweinstock marked this pull request as ready for review September 3, 2026 19:39
@nborges-aws
nborges-aws merged commit dffe6e5 into aws:refactor Sep 3, 2026
22 of 25 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (a665955) to head (003dee1).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2192   +/-   ##
=========================================
  Coverage     97.15%   97.15%           
=========================================
  Files           542      542           
  Lines         37728    37728           
=========================================
  Hits          36653    36653           
  Misses         1075     1075           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for the report, @codecov-commenter — feedback like this is exactly
how we catch the things we missed. Because this PR is already
closed, the team won't see follow-up comments here.

Would you mind opening a new issue so we can track it properly?
https://github.com/aws/agentcore-cli/issues/new/choose

If this is a security issue, please report it privately via
https://aws.amazon.com/security/vulnerability-reporting/ instead
of a public issue.

This was referenced Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants