fix(tui): wrap long JSON values in detail views - #2212
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, well-scoped fix. CodeBlock already accepted a wrap prop; JsonDetail just wasn't passing it, so long JSON values (like a multi-sentence systemPrompt) were being truncated with …. Toggling wrap on skips the truncation branch in CodeBlock.renderLine and lets Ink's <Text> wrap naturally within the ScrollView.
The test is a genuine behavior check, not a snapshot: it builds a ~245‑char prompt with a WRAP_SENTINEL at the end, renders at the default 100-column test width, and asserts the sentinel appears in the frame. Without wrap, the sentinel would be sliced off by the truncation in CodeBlock.renderLine, so it correctly guards against regression. Mocking is limited to TestCoreClient at the SDK boundary — appropriate. No telemetry needed for a rendering fix.
Nothing blocking — good to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2212 +/- ##
=========================================
Coverage 97.08% 97.08%
=========================================
Files 544 544
Lines 37869 37870 +1
=========================================
+ Hits 36765 36766 +1
Misses 1104 1104 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Wrap long JSON values in TUI detail views instead of truncating them.
Adds regression coverage for long harness prompts.
before:

after:
