Skip to content

chore(tui): align TUI copy with the CLI help descriptions - #2213

Open
notgitika wants to merge 2 commits into
aws:refactorfrom
notgitika:chore/tui-copy-consistency
Open

chore(tui): align TUI copy with the CLI help descriptions#2213
notgitika wants to merge 2 commits into
aws:refactorfrom
notgitika:chore/tui-copy-consistency

Conversation

@notgitika

@notgitika notgitika commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #2207: ran the same description audit across the TUI by rendering all 163 routes and checking every user-visible string against the same rules.

  • added the 16 missing header descriptions (the list screens and project create), each verbatim the CLI description for that command
  • resource nouns match the CLI — harness lowercase, AgentCore/Runtime/Gateway/Memory/Target/Rule capitalized; ID/ARN/URL/MCP/API initialisms in table headers and wizard fields
  • transient status text starts lowercase and uses a real ellipsis
  • key hints use one spelling per action (navigate, open, back, ↑↓/jk)
  • HarnessWizard's provider copy now matches the newer project create wizard

Picker steps keep their own wording (choose a Gateway to list Rules for) rather than the terminal command's description, since the step is a picker.

@github-actions github-actions Bot added the size/m PR size: M label Sep 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 3, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Pure copy/UX polish PR (plus threading a description prop through HarnessWizard). Changes are internally consistent:

  • Proper-noun capitalization normalized (Bedrock, OpenAI, Gemini, LiteLLM, AgentCore, MCP)
  • Initialisms uppercased (id → ID, arn → ARN, url → URL) in labels/help text/column headers
  • Spinner labels sentence-cased (loading…Loading…, working…Working…, creating…Creating…)
  • "...""…" and ↑↓/kj↑↓/jk normalized
  • Key-hint verbs standardized (choose/movenavigate, cancelback)
  • List screens gain description subtitles

All affected tests are updated in lockstep with the copy changes, so the assertion drift risk is handled. No new logic, no I/O paths, no telemetry-worthy behavior — instrumentation isn't needed here.

One thing worth confirming (not a blocker): the intentional asymmetric casing of "Runtime" vs "harness" in shared strings like "a Runtime or harness invoke subcommand is required with --json" and "No deployed Runtimes or harnesses were found...". It's applied consistently across the diff, so I'm assuming this reflects the deliberate style convention (Runtime as a branded product noun, harness as a common noun). If that's not the intent, worth aligning them.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 3, 2026
@codecov-commenter

codecov-commenter commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.82353% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.04%. Comparing base (da28031) to head (d1ffa30).

Files with missing lines Patch % Lines
src/handlers/project/create/screen.tsx 92.30% 1 Missing ⚠️
src/handlers/project/invoke/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2213   +/-   ##
=========================================
  Coverage     97.04%   97.04%           
=========================================
  Files           544      544           
  Lines         37536    37556   +20     
=========================================
+ Hits          36428    36448   +20     
  Misses         1108     1108           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash
tejaskash previously approved these changes Sep 3, 2026
nborges-aws
nborges-aws previously approved these changes Sep 3, 2026
AlexanderRichey
AlexanderRichey previously approved these changes Sep 4, 2026
Comment thread src/components/EndpointWizard.tsx Outdated
<>
<Question text="which harness version should this endpoint serve?" />
<Spinner label="loading versions…" />
<Spinner label="Loading versions…" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to do all lowercase? Otherwise all looks good. Approving.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the spinner labels as well good catch!

Hweinstock
Hweinstock previously approved these changes Sep 4, 2026

@Hweinstock Hweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aligned with our fellow gen z :)

Thanks for taking the time to address these!

@github-actions github-actions Bot added size/m PR size: M and removed size/m PR size: M labels Sep 4, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 4, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 4, 2026
@github-actions github-actions Bot added size/l PR size: L and removed size/m PR size: M labels Sep 4, 2026
@notgitika
notgitika force-pushed the chore/tui-copy-consistency branch from dcb3f4e to 917ffef Compare September 4, 2026 05:13
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 4, 2026
@github-actions github-actions Bot added size/m PR size: M and removed size/l PR size: L labels Sep 4, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 4, 2026
gitikavj added 2 commits September 4, 2026 01:17
Ran the --help description audit across every TUI screen: rendered all 163
routes and checked each user-visible string against the same rules.

- header descriptions: added the missing 16 (list screens and project
  create), each verbatim the CLI description for that command
- resource nouns match the CLI (harness lowercase, AgentCore/Runtime/
  Gateway/Memory/Target/Rule capitalized); ID/URL/ARN/MCP initialisms
- status text is sentence case with a real ellipsis
- key hints use one spelling per action (navigate, open, back, ↑↓/jk)
- HarnessWizard's provider copy now matches the newer project create
  wizard
@notgitika
notgitika force-pushed the chore/tui-copy-consistency branch from 917ffef to d1ffa30 Compare September 4, 2026 05:26
@github-actions github-actions Bot added size/m PR size: M and removed size/m PR size: M labels Sep 4, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 4, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants