chore(tui): align TUI copy with the CLI help descriptions - #2213
chore(tui): align TUI copy with the CLI help descriptions#2213notgitika wants to merge 2 commits into
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Pure copy/UX polish PR (plus threading a description prop through HarnessWizard). Changes are internally consistent:
- Proper-noun capitalization normalized (Bedrock, OpenAI, Gemini, LiteLLM, AgentCore, MCP)
- Initialisms uppercased (id → ID, arn → ARN, url → URL) in labels/help text/column headers
- Spinner labels sentence-cased (
loading…→Loading…,working…→Working…,creating…→Creating…) "..."→"…"and↑↓/kj→↑↓/jknormalized- Key-hint verbs standardized (
choose/move→navigate,cancel→back) - List screens gain
descriptionsubtitles
All affected tests are updated in lockstep with the copy changes, so the assertion drift risk is handled. No new logic, no I/O paths, no telemetry-worthy behavior — instrumentation isn't needed here.
One thing worth confirming (not a blocker): the intentional asymmetric casing of "Runtime" vs "harness" in shared strings like "a Runtime or harness invoke subcommand is required with --json" and "No deployed Runtimes or harnesses were found...". It's applied consistently across the diff, so I'm assuming this reflects the deliberate style convention (Runtime as a branded product noun, harness as a common noun). If that's not the intent, worth aligning them.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2213 +/- ##
=========================================
Coverage 97.04% 97.04%
=========================================
Files 544 544
Lines 37536 37556 +20
=========================================
+ Hits 36428 36448 +20
Misses 1108 1108 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| <> | ||
| <Question text="which harness version should this endpoint serve?" /> | ||
| <Spinner label="loading versions…" /> | ||
| <Spinner label="Loading versions…" /> |
There was a problem hiding this comment.
I thought we were going to do all lowercase? Otherwise all looks good. Approving.
There was a problem hiding this comment.
fixed the spinner labels as well good catch!
Hweinstock
left a comment
There was a problem hiding this comment.
aligned with our fellow gen z :)
Thanks for taking the time to address these!
917ffef
|
Claude Security Review: no high-confidence findings. (run) |
dcb3f4e to
917ffef
Compare
|
Claude Security Review: no high-confidence findings. (run) |
Ran the --help description audit across every TUI screen: rendered all 163 routes and checked each user-visible string against the same rules. - header descriptions: added the missing 16 (list screens and project create), each verbatim the CLI description for that command - resource nouns match the CLI (harness lowercase, AgentCore/Runtime/ Gateway/Memory/Target/Rule capitalized); ID/URL/ARN/MCP initialisms - status text is sentence case with a real ellipsis - key hints use one spelling per action (navigate, open, back, ↑↓/jk) - HarnessWizard's provider copy now matches the newer project create wizard
917ffef to
d1ffa30
Compare
|
Claude Security Review: no high-confidence findings. (run) |
Follow-up to #2207: ran the same description audit across the TUI by rendering all 163 routes and checking every user-visible string against the same rules.
project create), each verbatim the CLI description for that commandharnesslowercase, AgentCore/Runtime/Gateway/Memory/Target/Rule capitalized;ID/ARN/URL/MCP/APIinitialisms in table headers and wizard fieldsnavigate,open,back,↑↓/jk)HarnessWizard's provider copy now matches the newerproject createwizardPicker steps keep their own wording (
choose a Gateway to list Rules for) rather than the terminal command's description, since the step is a picker.