ci(release): placeholder release-prepare workflow so refactor's can be dispatched - #2226
Merged
Conversation
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, self-contained CI change. Verified the mechanics:
.github/workflows/release-prepare.ymlfilename andname: release-preparematch refactor's copy, so dispatching with--ref refactorcorrectly picks up refactor's workflow (including itsbump/channelinputs) while--ref mainruns this placeholder.- The placeholder has no
checkout, no write permissions, and no inputs — it just prints a::error::andexit 1, so nothing on main is touched if someone accidentally dispatches against main. - No existing
release-prepare.ymlon main to conflict with, andrelease.yml/release-main-and-preview.ymlare untouched as claimed. - Telemetry/mocking guidance is N/A here (CI-only change, no runtime or test code).
The self-documenting comment at the top clearly explains why the file exists and when to remove it. Nothing blocking.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-2226-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.1.tgz |
Contributor
Coverage Report
|
notgitika
approved these changes
Sep 4, 2026
Hweinstock
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
The refactor branch has its own release process, merged in #2206:
release-prepare.ymlis dispatched by hand to open a release PR, andrelease-publish.ymlpublishes when that PR merges.GitHub only lists a workflow in the Actions UI and the dispatch API if a file with that name exists on the default branch.
release-prepare.ymlexists only on refactor, so today it cannot be dispatched at all:Main and refactor will stay separate for a while, and we need to cut
1.0.0-rc.1from refactor now. This PR adds a placeholderrelease-prepare.ymlto main so GitHub knows the name.What it does
Nothing to main. When you dispatch
release-prepare:release-prepare.ymlwith refactor's inputs (bump,channel). This is standard GitHub behavior: the selected branch's copy of the file runs.Main's own release process (
release.yml,release-main-and-preview.yml) is unchanged.When to remove it
When refactor lands on main, the real
release-prepare.ymloverwrites this file. Nothing else to clean up.release-publish.ymlneeds no placeholder. It runs onpull_request: closed, which reads the workflow from the PR's own branch.