feat(templates): support vercel typescript. - #2227
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2227 +/- ##
=========================================
Coverage 97.05% 97.05%
=========================================
Files 555 555
Lines 38385 38416 +31
=========================================
+ Hits 37253 37284 +31
Misses 1132 1132 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice, tightly-scoped addition. The new agent-typescript-vercel template is wired through consistently: schema (framework enum), shortcut entry (with supportsModelProviderOverride: false and includesMemory: false), resolver in runtime.ts, TUI template list, and reserved-name list (vercelai was already there). Tests cover the happy path, the "no memory" behavior, and the "reject --model-provider" validation, and use real fs rather than mocks. I verified the package pins on npm — ai@~6.0.0 and @ai-sdk/amazon-bedrock@~4.0.0 share @ai-sdk/provider@3.0.15, so they're compatible; streamText and createAmazonBedrock({ credentialProvider }) match their current type signatures. fromNodeProviderChain()'s return shape is structurally compatible with the Omit<BedrockCredentials, 'region'> the provider expects.
A couple of minor observations, not blockers:
main.tshard-codesprocess.env.AWS_REGION ?? 'us-east-1'. In the AgentCore runtime and inproject dev(environment.tssetsAWS_REGION), this fallback will never fire, and the model ID uses aglobal.*cross-region inference profile, so this is safe — just noting that a user runningtsx watchoutsideproject devwithoutAWS_REGIONset would silently pin to us-east-1.- Unlike
agent-typescript-strands,package.json.templatehas nooverridesblock forbedrock-agentcorepeer deps. That looks intentional since the Vercel template doesn't depend on@strands-agents/sdk, but worth double-checking thatbedrock-agentcore@~0.3.0doesn't have a peer dep that npm will complain about with these deps.
Nothing here needs to change before merging.
Problem
The refactor branch does not yet support any TS templates beyond strands. We want to also support a simple vercel template.
Solution
agent-typescript-verceland have it render a Vercel AI SDK base into their project on both project creation and add runtime.Verification:
Create Flow CLI
Create Flow TUI