Skip to content

fix(tui): reorder project creation options - #2228

Merged
tejaskash merged 1 commit into
refactorfrom
fix/create-tui-agent-code-order
Sep 4, 2026
Merged

fix(tui): reorder project creation options#2228
tejaskash merged 1 commit into
refactorfrom
fix/create-tui-agent-code-order

Conversation

@notgitika

Copy link
Copy Markdown
Contributor

Summary

  • list agent code before harness in the project create TUI
  • remove the (recommended) label from harness
  • keep harness as the existing default selection
  • update wizard tests for the new ordering

Verification

  • bun test — 2,987 pass, 0 fail
  • bun run typecheck
  • bun run lint:check
  • bun run format:check

@github-actions github-actions Bot added the size/s PR size: S label Sep 4, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 4, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 4, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, self-consistent UI change: reorders PROJECT_KIND_OPTIONS so "agent code" appears before "harness" and drops the "(recommended)" label. The default in emptyCreateProjectForm remains kind: "harness", so harness is still preselected — which is why the tests correctly switch from down to up to navigate to "agent code" (now at index 0 vs. harness at index 1). The new assertion on indexOf in create.screen.test.tsx also correctly pins the visual ordering.

Nothing that needs changing before merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 4, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.05%. Comparing base (9175ad4) to head (dd96d2e).
⚠️ Report is 2 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2228   +/-   ##
=========================================
  Coverage     97.05%   97.05%           
=========================================
  Files           555      555           
  Lines         38385    38385           
=========================================
+ Hits          37253    37255    +2     
+ Misses         1132     1130    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskash merged commit 5699aa4 into refactor Sep 4, 2026
20 of 21 checks passed
@tejaskash
tejaskash deleted the fix/create-tui-agent-code-order branch September 4, 2026 18:45
@Hweinstock

Copy link
Copy Markdown
Contributor

I think even though agent code is on the top, its still not selected by default:
image

When I ran through a fresh TUI harness was selected by default.

I also think we should remove the reccomended here:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants