Skip to content

Improve error handling for existing directories #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamWillden wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error handling for existing directories #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/installer/commands/make_directory_command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,18 @@ impl MakeDirectoryCommand {
}

/// # Errors
/// Returns an error if the command execution fails.
/// Returns an error if the command execution fails, unless the path already exists
pub fn execute(&self, cleanup_file: &mut dyn Write) -> Result<()> {
fs::create_dir(&self.directory)?;
writeln!(cleanup_file, "{}", self.directory.display())?;
match fs::create_dir(&self.directory) {
Ok(()) => {
writeln!(cleanup_file, "{}", self.directory.display())?;
}
Err(e)
if e.kind() == std::io::ErrorKind::AlreadyExists
&& self.directory.is_dir() => {}
Err(e) => return Err(e.into()),
}

Ok(())
}

Expand Down