test(chat-client): add postMessage origin check regression tests#2783
Open
laileni-aws wants to merge 1 commit into
Open
test(chat-client): add postMessage origin check regression tests#2783laileni-aws wants to merge 1 commit into
laileni-aws wants to merge 1 commit into
Conversation
Add comprehensive regression tests for the same-origin guard in handleInboundMessage (P389799154). Tests assert: - Foreign-origin messages are rejected across 6 command types - Multiple untrusted origins are blocked - Same-origin messages continue to process normally - Rejection logs console.warn without throwing This prevents the XSS mitigation from silently regressing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive regression tests for the same-origin guard in
handleInboundMessage(P389799154) to prevent the XSS mitigation from silently regressing.New tests (15 total)
Rejects foreign-origin messages across command types
CHAT_REQUEST_METHOD,SEND_TO_PROMPT,ERROR_MESSAGE,GENERIC_COMMAND,CHAT_OPTIONS,OPEN_TAB_REQUEST_METHOD— all verified to only produce rejection telemetry, not command-handler output.Rejects messages from various untrusted origins
https://attacker.example.com,http://evil.localhost,https://phishing.internal.corpSame-origin messages are processed normally
SEND_TO_PROMPT,CHAT_REQUEST_METHOD, andOPEN_TAB_REQUEST_METHODstill work from same-origin.Rejection is observable without throwing
console.warnfires with the untrusted origin stringAudit results
Only one
window.addEventListener('message', ...)exists in chat-client/src — the one inchat.ts. No unguarded message sinks found.Testing