fix: [Select/MultiSelect/FieldSelect] refinements (ENG-46730, 46731, 46732, 46739)#782
Open
isaquebock wants to merge 6 commits into
Open
fix: [Select/MultiSelect/FieldSelect] refinements (ENG-46730, 46731, 46732, 46739)#782isaquebock wants to merge 6 commits into
isaquebock wants to merge 6 commits into
Conversation
…30-32, ENG-46739)
The document-level pointerdown handler in select-content closed the panel whenever the pointer landed outside the content root — including on the trigger itself. The trigger's @click then re-opened it, so closing the open panel via the trigger appeared to require a second click and could emit update:open twice per press. Skip the outside-close path when the pointerdown lands on the trigger; the trigger's own handler drives the toggle. Adds two regression tests exercising a real pointerdown+click sequence: one asserts the panel closes after a trigger press while open, the other asserts one open transition per press. Also lands focus-visible tests for ENG-46730 asserting ArrowDown moves DOM focus onto the options. Refs: ENG-46730, ENG-46739
FieldSelect composes Label + Select (with Trigger + Content + Option
sub-components) + HelperText into a single vertical stack, mirroring
FieldText's role for text inputs. Options are supplied via a data prop
(`options: { value, label }[]`) so the field owns the rendering;
consumers who need slot-based composition can drop to the underlying
Select compound directly.
Includes the spec (.specs/field-select.md, monolithic structure), the
flat exports entry, a size-limit budget (6 KB), a minimal Storybook
story with Default/Sizes/Required/Invalid/Disabled/Multiple, and a
functional test suite covering data-testid derivation, label/for/id
wiring, aria-describedby / aria-required / aria-invalid, disabled
suppression, size variants, option rendering + selection, and axe
runs on the default and disabled states.
Refs: ENG-46732
5 tasks
isaquebock
marked this pull request as ready for review
July 23, 2026 17:33
isaquebock
marked this pull request as draft
July 23, 2026 17:34
isaquebock
marked this pull request as ready for review
July 23, 2026 21:02
Contributor
menu do Select esta abrindo errado quando é feito zoom no story |
Contributor
MultiSelect ta ficando com as bordas por baixo para as primeiras opçoes
|
Contributor
|
O FieldSelect fica alterando a largura conforme selecionamos mais itens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refinamentos ao Select V4 cobrindo 4 bugs do épico.
SelectOption; adicionados testes de regressão para navegação viaArrowDown(foco visível e wrap).select-content.vueusa o novo token--z-input-overlay: 1100desse PR (não modificado aqui para evitar conflito).FieldSelect(Label + Select + HelperText),v-modelviadefineModel, seguindo padrãoFieldText.onDocumentPointerDown(capture phase) fechava o painel ao pointerdown no próprio trigger, e o@clickdo trigger reabria. Bailout adicionado quandotriggerRef.contains(target).How to test (mapeado 1:1 com Jira)
ENG-46730 — "Focus state por teclado não funciona nas opções"
ArrowDown→ primeira opção exibe o focus ring visível (destaque visual da opção em foco por teclado).ArrowDownsucessivos movem o ring; do último volta para o primeiro (wrap).Escapefecha e devolve o foco para o trigger.ENG-46731 — "Dropdown renderiza atrás de Drawer/Dialog (z-index)"
<Select>ou<MultiSelect>dentro de um<Drawer>ou<Dialog>aberto.MultiSelect(mesmo fix, aplicado nomulti-select-content).ENG-46732 — "Criar componente FieldSelect (faltando)"
Default— Label acima, Select no meio, HelperText abaixo — análogo aos demais Field*.Sizes,Required,Invalid,Disabled,Multiplerenderizam corretamente ev-modelfunciona.ENG-46739 — "Clique duplicado ao selecionar opção"
update:open→ apenas 1 evento por clique no trigger.update:modelValuedispara apenas uma vez (não duas).Dependencies
Requer merge de #783 (ENG-46735) primeiro — traz o token
--z-input-overlayque resolve ENG-46731.