Repository navigation
feat(sdk): expose terminal platform disconnects to hosts - #843
Closed
bandzalkin wants to merge 3 commits into
Closed
bandzalkin wants to merge 3 commits into
bandzalkin wants to merge 3 commits into
Conversation
This was referenced Oct 18, 2026
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 19, 2026
Source-Base: a96fb54 Source-Head: 5ea3a0d Upstream-PR: band-ai#843
bandzalkin
force-pushed
the
feat/host-disconnect-reason-refresh
branch
from
October 20, 2026 06:36
5ea3a0d to
92b0282
Compare
bandzalkin
requested review from
AlexanderZ-Band and
amit-gazal-band
as code owners
October 20, 2026 06:36
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 20, 2026
Source-Base: ecd2b1b Source-Head: 92b0282 Upstream-PR: band-ai#843
bandzalkin
force-pushed
the
feat/host-disconnect-reason-refresh
branch
from
October 20, 2026 11:48
92b0282 to
e4387f2
Compare
bandzalkin
added a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 20, 2026
band-ai#763 deletes omp_acp.py while band-ai#841 edits it; every branch that carries the stack's tree must apply its own changes before that deletion, so band-ai#843-band-ai#852 precede band-ai#763 and the native OMP family follows it.
bandzalkin
added a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 20, 2026
band-ai#763 deletes omp_acp.py while band-ai#841 edits it; every branch that carries the stack's tree must apply its own changes before that deletion, so band-ai#843-band-ai#852 precede band-ai#763 and the native OMP family follows it.
Main now reconnects on a peer normal close (reconnect_on_normal_close), so transport completion is signal_cancel or a policy close: drop normal_close from the completion matrices and let the linkclose model accept a run that ends by raising AgentDisconnectedError with its typed reason, as the surface feature specifies.
bandzalkin
force-pushed
the
feat/host-disconnect-reason-refresh
branch
from
October 21, 2026 00:30
e4387f2 to
bf0828c
Compare
bandzalkin
added a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
…main) # Conflicts: # README.md # src/band/agent.py # src/band/runtime/platform_runtime.py # tests/agent/test_disconnect_real_wire.py # tests/agent/wirekit.py
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: ed88607 Source-Head: bf0828c Upstream-PR: band-ai#843
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: ed88607 Source-Head: bf0828c Upstream-PR: band-ai#843
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: ed88607 Source-Head: bf0828c Upstream-PR: band-ai#843
Contributor
Author
|
Closing: band-agent does not consume this; may be re-proposed per feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This gives managed hosts a public way to distinguish a terminal platform disconnect from an intentional stop or a temporary network outage, so they can respond to an identity conflict instead of blindly reconnecting.
AgentDisconnectedError, aBandConnectionErrorcarrying the typedWebSocketDisconnectReason, when the platform ends the connection lifecycle. The waiter wakes even if the server leaves the socket open.Agent.last_disconnect_reasonandPlatformRuntime.last_disconnect_reason; retain it afterstop()and clear it on a fresh connection attempt.run_forever()does not stop a live transport. Observe completed transport shutdown independently of the waiter, without letting an old transport affect a restarted run.Hosts still need
stop()or the existing context-managed lifecycle to settle owned resources. A terminal disconnect now raises rather than looking like a successfulrun_forever()return.Validation
Loopback WebSocket tests cover terminal disconnects, stop races, cancelled waiters, reconnects, and stale transport generations.