Repository navigation
feat(mcp): resolve room-scoped servers during owned Claude SDK startup - #856
Closed
bandzalkin wants to merge 13 commits into
Closed
bandzalkin wants to merge 13 commits into
bandzalkin wants to merge 13 commits into
Conversation
This was referenced Oct 19, 2026
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 19, 2026
Source-Base: 89742de Source-Head: 6156ab2 Upstream-PR: band-ai#856
bandzalkin
force-pushed
the
feat/claude-owned-mcp-resolver
branch
from
October 20, 2026 06:36
6156ab2 to
eb1e479
Compare
bandzalkin
requested review from
AlexanderZ-Band and
amit-gazal-band
as code owners
October 20, 2026 06:36
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 20, 2026
Source-Base: cad1f8b Source-Head: eb1e479 Upstream-PR: band-ai#856
Port the reviewed cancellation correction from dd8f3af..942759f4. Delegate acquisition cancellation explicitly to the matching startup owner, preserve first abandonment/cleanup diagnostics, and cover public caller/cleanup orderings after uncancel. Keep Claude-owned retention changes in the stacked Claude PR.
bandzalkin
force-pushed
the
feat/claude-owned-mcp-resolver
branch
from
October 20, 2026 11:46
eb1e479 to
17c575a
Compare
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 10178db Source-Head: 17c575a Upstream-PR: band-ai#856
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 10178db Source-Head: 17c575a Upstream-PR: band-ai#856
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 10178db Source-Head: 17c575a Upstream-PR: band-ai#856
Contributor
Author
|
Closing: band-agent does not consume this; may be re-proposed per feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Claude SDK rooms need current external MCP configuration at connection time, including refreshed authorization, without weakening ownership of partially started clients. Cancellation can arrive while the SDK is checking its executable, creating a backend, writing configuration, or publishing a native child; each of those resources must remain owned until cleanup finishes.
What changes
Dependency
Builds on #855 for the shared startup and turn-lifecycle ownership changes. Claude host preflight and model discovery are separate concerns in #847 and #851.
Validation
Tests exercise resolver snapshots and precedence, cancellation during startup, cleanup retry, physical child custody, and the actual SDK transport-constructor handoff.