feat: gate activity tool names on the tool-call emit choice by bandzalkin · Pull Request #874 · band-ai/band-sdk-python

bandzalkin · 2026-10-20T11:37:08Z

Part of the INT-1744 producer stack, stacked on #841.

Adapters already gate tool-call narration on Emit.TOOL_CALLS. #841 reports tool names in the live activity detail regardless of that choice, so an agent configured without tool narration still leaks names into the room through the indicator. This PR aligns the two: the choice is read once per turn in SimpleAdapter.on_event and enforced at the activity observer every reporter funnels through, so no adapter can bypass it. permission and memory activity name no content and report either way.

If the producers stack should instead grow the gate inside #841, happy to fold these commits there and close this — the tests in tests/runtime/activity/test_namegate.py carry over unchanged.

Tests: tool_call frames carry the name with Emit.TOOL_CALLS and degrade to nameless reasoning without it; wrapper removal fails the guard.

…porter

Give the repeated tool-completion and privacy checks one helper, and name the ACP call record so activity identity is not a bare tuple. Co-authored-by: Cursor <cursoragent@cursor.com>

…t-activity-detail-to-the-platform-INT-1744 Keep main's BackendTurns ownership of OpenCode cancellation and register the watcher as a turn worker so activity reporting outlives the handler. Reporter unit tests move to tests/runtime/workingreporter; main's workingstate package keeps the execution-level tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AgnNR4uiqD787Bg3yKdZpL

…detail-to-the-platform-INT-1744' into feat/python-sdk-report-activity-detail-to-the-platform-delivery-INT-1744 Port the startup-backlog claim-failure test edit to the split tests/runtime/execution package. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AgnNR4uiqD787Bg3yKdZpL

…detail-to-the-platform-delivery-INT-1744' into feat/python-sdk-report-activity-detail-to-the-platform-producers-INT-1744 Adopt main's agno and tool test layouts and carry the producer edits into them; keep the split CrewAI/Parlant coverage guards with main's new paths. Letta streams provider events through main's BackendTurns run, and the CrewAI flow tool activity wraps main's turn-owned tool execution. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AgnNR4uiqD787Bg3yKdZpL

It runs three collect-only subprocesses, which exceeded the default per-test timeout on Windows runners. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AgnNR4uiqD787Bg3yKdZpL

…t-activity-detail-to-the-platform-INT-1744

…detail-to-the-platform-INT-1744' into feat/python-sdk-report-activity-detail-to-the-platform-delivery-INT-1744

…detail-to-the-platform-delivery-INT-1744' into feat/python-sdk-report-activity-detail-to-the-platform-producers-INT-1744

Adapters that do not report tool calls must not leak tool names through the live room indicator. The decision is taken once per turn in SimpleAdapter from the negotiated emit set and enforced at the single observer every activity reporter funnels through, so no adapter can bypass it. Permission and memory detail name no content and always report. Guards: tests/runtime/activity/test_namegate.py pins that a tool_call frame reaches the wire with Emit.TOOL_CALLS and degrades to nameless reasoning without it; fails if the wrapper is removed.

…t-activity-detail-to-the-platform-delivery-INT-1744 # Conflicts: # docs/turn-outcome.md # src/band/platform/message_lifecycle.py # src/band/runtime/execution.py # src/band/runtime/working_state.py # tests/runtime/activityownership/conftest.py # tests/runtime/activityownership/kit.py

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFmR3J53UqbsYDMmTUd3Rb

The SaaS default rest_url (app.band.ai) serves the frontend at /api/version, so discovery latched every default process to boolean reporting. Every agent API response already carries X-API-Version, so the activity POST itself now teaches the process whether detail is supported. This removes the discovery GET, its rest_url plumbing, the half-budget split and the cross-loop owner/waiter coordination. The 422 downgrade now logs the room and body, and an unadvertised version is logged at debug. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFmR3J53UqbsYDMmTUd3Rb

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

Source-Base: d697f43 Source-Head: 89dab59 Upstream-PR: band-ai#874

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

Source-Base: d697f43 Source-Head: 89dab59 Upstream-PR: band-ai#874

The mask wrapper was attached only when the flag was already off, so an adapter that binds its observer before the emit sync (codex's item/started path) kept reporting named tool_calls after the choice was turned off. The observer now always wraps and reads the live flag on every report; the hook site gates on the OMP branch remain as the second guard. Red-first test: observer bound with names on, choice flipped off mid-turn, tool report must arrive nameless. Co-Authored-By: Claude <noreply@anthropic.com>

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

Source-Base: d697f43 Source-Head: d764959 Upstream-PR: band-ai#874

bandzalkin · 2026-10-21T15:37:51Z

Closing: superseded by in-repo PR(s) #901 with the same content, one concern each and a clean single-author history.

Select upstream band-ai#841 (activity producers, carrying band-ai#839/band-ai#840 via forward merges), band-ai#874 after 841 (tool-name emit gate with the I-08 name clamp), the host stack ahead of band-ai#763, band-ai#763 after 874 (native OMP with the tool/permission activity hooks and omp_acp retirement), and band-ai#854/band-ai#795/band-ai#848 after 763. Replayed from the branches' live heads.

AlexanderZ-Band and others added 23 commits October 18, 2026 13:33

fix: Keep working-state reporting alive through provider turns

d1419b7

fix: Preserve standalone worker binding across tool wrappers

8ec26b3

test: Avoid the E2E peer fixture reservation in runtime tests

1476457

style: Format the renamed activity platform fixture

8bfeac0

test: Use real time for randomized scheduler grace controls

a397d8c

feat: Deliver compatible activity detail through the working-state re…

0342d96

…porter

style: Format detail ownership fixture parameters

d76f571

test: Avoid reserved peer fixtures in activity wire tests

1842638

test: Preserve backlog ordering across valid recovery retries

06d8124

feat: Map provider and Band tool progress to room activity

2d69703

test: Validate activity producers through real execution boundaries

64de362

refactor: Consolidate activity reset and streaming usage ownership

831b851

test: Register live activity cells and disambiguate runtime fixtures

9d7fc64

fix: Fence housekeeping activity and clean up cancelled tool starts

eb7326e

refactor: Share activity observation records and assertions

a674b67

Give the repeated tool-completion and privacy checks one helper, and name the ACP call record so activity identity is not a bare tuple. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge remote-tracking branch 'origin/main' into feat/python-sdk-repor…

f2ff776

…t-activity-detail-to-the-platform-INT-1744

Merge remote-tracking branch 'origin/feat/python-sdk-report-activity-…

2f4082e

…detail-to-the-platform-INT-1744' into feat/python-sdk-report-activity-detail-to-the-platform-delivery-INT-1744

Merge remote-tracking branch 'origin/feat/python-sdk-report-activity-…

36ba9a1

…detail-to-the-platform-delivery-INT-1744' into feat/python-sdk-report-activity-detail-to-the-platform-producers-INT-1744

bandzalkin requested review from AlexanderZ-Band and amit-gazal-band as code owners October 20, 2026 11:37

This was referenced Oct 20, 2026

feat: Report Band tool calls as turn activity #841

Merged

chore(fork): carry the typed agent activity stack bandzalkin/band-sdk-python#10

Merged

AlexanderZ-Band and others added 3 commits October 20, 2026 15:12

refactor: Flatten the activity compatibility retry

6a62878

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFmR3J53UqbsYDMmTUd3Rb

bandzalkin added 2 commits October 21, 2026 02:50

style: drop merge-seam blank lines from the reporter files

d697f43

Merge band-ai#841 (format fix on the activity stack)

89dab59

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 20, 2026

Merge band-ai#874 (format fix through the activity stack)

2dc539a

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 20, 2026

Merge band-ai#874 (format fix on the activity stack)

b470206

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

feat: gate activity tool names on the tool-call emit choice

b3b9ec0

Source-Base: d697f43 Source-Head: 89dab59 Upstream-PR: band-ai#874

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

feat: gate activity tool names on the tool-call emit choice

a23b4d6

Source-Base: d697f43 Source-Head: 89dab59 Upstream-PR: band-ai#874

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#763

3098914

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#845

df3d2bc

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#846

07bb303

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#847

eae7103

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#850

447e419

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#851

315e189

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#852

8dfc639

bandzalkin added a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

Merge band-ai#874 (live tool-name gate) into band-ai#844

5f3910a

bandzalkin mentioned this pull request Oct 21, 2026

fix(integrations): preserve native OMP lifecycle and prompt authority #763

Closed

github-actions Bot pushed a commit to bandzalkin/band-sdk-python that referenced this pull request Oct 21, 2026

feat: gate activity tool names on the tool-call emit choice

0312e0f

Source-Base: d697f43 Source-Head: d764959 Upstream-PR: band-ai#874

bandzalkin mentioned this pull request Oct 21, 2026

feat: gate activity tool names on the tool-call emit choice #901

Open

bandzalkin closed this Oct 21, 2026

Navigation Menu

Repository navigation

feat: gate activity tool names on the tool-call emit choice - #874

feat: gate activity tool names on the tool-call emit choice#874
bandzalkin wants to merge 47 commits into
band-ai:mainfrom
bandzalkin:feat/gate-activity-tool-names

bandzalkin commented Oct 20, 2026

Uh oh!

bandzalkin commented Oct 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bandzalkin commented Oct 20, 2026

Uh oh!

bandzalkin commented Oct 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants