Repository navigation
fix: keep a Band tool's identity for an oversized integer payload - #894
Open
bandzalkin wants to merge 1 commit into
Open
bandzalkin wants to merge 1 commit into
bandzalkin wants to merge 1 commit into
Conversation
json.loads raises a bare ValueError, not JSONDecodeError, when an integer literal exceeds the interpreter's digit limit. That payload escaped the device-write normalizer and failed the turn instead of reaching the tool as a refused call under its own name.
This was referenced Oct 21, 2026
bandzalkin
added a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
bandzalkin
added a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 21, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
bandzalkin
marked this pull request as ready for review
October 22, 2026 01:54
bandzalkin
requested review from
AlexanderZ-Band and
amit-gazal-band
as code owners
October 22, 2026 01:54
AlexanderZ-Band
approved these changes
Oct 22, 2026
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 22, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
bandzalkin
changed the title
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 22, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
github-actions Bot
pushed a commit
to bandzalkin/band-sdk-python
that referenced
this pull request
Oct 22, 2026
Source-Base: 490e2d7 Source-Head: 71255e4 Upstream-PR: band-ai#894
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
normalize_omp_mcp_device_callparses an executed device write's JSON payload and only catchesjson.JSONDecodeError.json.loadsraises a bareValueErrorwhen an integer literal exceeds the interpreter's digit limit, so that payload escapes the normalizer and fails the turn instead of reaching the tool as a refused call under the tool's own name. Both the ACP-bridged and the native OMP adapter go through this function.What
Catch
ValueError(the superclass) so an oversized-integer payload is treated like any other malformed write. The regression test fails onmainand passes with the fix.Scope
One
exceptclause inband.integrations.omp; no behavior change for payloads that already parsed. Carved out of #763.