Repository navigation
fix(highlight): repaint after filetype retry - #434
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A generated review can contain a hunk whose filetype is unknown while
did_filetype()is nonzero. The scheduled retry invalidates the cache andsupersedes the deferred syntax job. Its bare redraw does not run the
decoration provider’s
on_buf, sopending_clearremains set. The reviewthen shows diff backgrounds without language syntax until
:edit.Solution
Rebuild the cache and process
pending_clearinside the scheduled retrybefore
redraw!. The redraw now sees current hunks and an empty highlightedset, so it schedules language syntax immediately.