Skip to content

Remove normalization of paths for macOS#9

Description

@rmehner

馃憢

Gatsby started using this project in a recent release and unfortunately it lead to a new bug (gatsbyjs/gatsby#12005 (comment)) I've dug a bit deeper and found that it is caused by this line:

if (process.platform === 'darwin') fsPathNormalized = fsPathNormalized.normalize('NFD')

HFS+ is no longer the default file system for newer Macs and with High Sierra they even upgraded HFS+ systems to APFS if the computer is using a SSD.

APFS seems to not store things with NFD anymore, but if we try to normalize the path, glob will return an empty array for the normalized path. If we remove that line, everything works as expected.

Unfortunately I don't have any old mac with HFS anymore, so I can't test it out right now, but what do you think the best way going forward would be?

There's also #8 lingering around, which I have yet to try.

Thanks for reading this and have a great day :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions