Keep the silent sign-in test out of the developer's keyring - #338
Merged
Conversation
TestSetupSilentSuccessKeepsSignInInstructions stubs the interactive login and asserts its instructions surface, but auth.NewManager consulted the real system keyring first. On a machine where the developer is signed in to HEY the wizard skips the stubbed login and the test fails; in CI, with no keyring, it passes. HEY_NO_KEYRING=1 confines it to its temp dir like every other auth-touching test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestSetupSilentSuccessKeepsSignInInstructionsstubsloginInteractivelyand asserts the sign-in instructions surface during a silent setup — but it builds itsauth.ManagerwithoutHEY_NO_KEYRING=1, so the manager consults the real system keyring first. On a developer machine that's signed in to HEY, the wizard concludes there's nothing to do, never calls the stub, and the test fails; in CI, with no keyring, it passes. This mademake releasefail its preflight on any signed-in machine.One line (plus the why):
HEY_NO_KEYRING=1, confining the test to its temp dir like every other auth-touching test in the package.