Repository navigation
Conversation
RELEASING.md: what v1 and vX.Y.Z mean and when v1 may move, how consumers pin, and the steps to cut a release. README and examples/ pin actions/checkout, the action itself (v1.1.0), and upload-sarif by commit SHA with the release in a trailing comment. The pre-commit examples use <release-commit-sha>: .pre-commit-hooks.yaml is in no release tag, so rev: v1 and rev: v1.1.0 fail with InvalidManifestError. scripts/check_pins.py and the Pins workflow fail a uses: or rev: that is not a 40-character SHA with a release comment, and compare this repo's own SHAs with their tags. action-smoke.yml keeps its deliberate @v1 with a pin-exempt mark. Closes #60 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015T9K217kxBqsUZ3omKYv9P Signed-off-by: chaksaray <chaksaray@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
What and why
INT-2. The README told people to use
bawbel/integrations@v1andactions/checkout@v4, a mutable tag, which is the practice this project's own scanner would flag.RELEASING.md: whatv1andvX.Y.Zmean, whenv1may move and when it may not, how consumers pin, and the release steps (tag, test, movev1, update the pins).examples/basic.yml,examples/sarif.yml:actions/checkout,bawbel/integrations(v1.1.0) andupload-sarifare pinned by commit SHA with the release in a trailing comment. The SHAs forcheckoutandupload-sarifare copied from workflows already pinned in this repo and in bawbel/scanner; I did not re-check them against the upstream tags.scripts/check_pins.py,tests/test_check_pins.py(25 tests) and.github/workflows/pins.yml: fail anyuses:orrev:that is not a 40-character SHA with a release comment, and compare this repo's own SHAs with the tag the comment names. It follows the rule that a number or pin in docs is checked by a script, not trusted..github/workflows/action-smoke.ymlkeeps its deliberate@v1and now carries# pin-exempt: .... Every other workflow was already pinned by SHA.@v1.I asked and was told to pin the examples to v1.1.0 now.
Action inputs and outputs
action.ymlis unchanged.Inputs added: none
Inputs renamed or removed: none
Outputs added: none
Outputs renamed or removed: none
Things you need to know (found while doing this)
v1is older than the latest release.gh api repos/bawbel/integrations/commits/v1 --jq .shagivesd57f114...(2026-04-25);.../commits/v1.1.0givesee77de3...(2026-04-26). RELEASING.md saysv1points at the newestv1.x.y, which describes the intended state, not today's.git merge-base --is-ancestor 4757cd8 <tag>says no forv1,v1.0.1andv1.1.0. At v1.1.0 the scan step writes${{ inputs.* }}straight into the shell and ends the scan with|| echo "[]", so a scanner error reads asclean. So both@v1and the pinned@v1.1.0in the new examples run that older action until a release includes fix: fail closed when the scanner fails, and pass inputs through env #37..pre-commit-hooks.yamlwas added on 2026-05-02 (feat: Pre commit hook #12), after v1.1.0. I reproduced the failure a user gets withrev: v1.1.0:So the pre-commit examples cannot be SHA-pinned to a real release yet. They show
rev: <release-commit-sha> # frozen: <release tag>, with a note saying no release contains the hooks. The checker lists those five placeholders so the release PR can fill them in.Verify (run this session)
Mutation check on a copy of the tree. Each change makes
check_pins.pyreport the right file and line:Checks
examples/pin every action andrevby commit SHA (python scripts/check_pins.py); the pre-commit examples use the documented placeholder, see item 3examples/match any changed action input or output (none changed)gh pr checks 61: 6 pass, 0 fail:pins,smoke,findings, and the three scannerfails closedjobs)Not verified
checkoutandupload-sarifSHAs against the upstream tags (copied from repo files already in use).examples/: it only reads.github/workflows, which is stated in RELEASING.md.pre-commit autoupdate --freezeoutput: my attempt to test it created a tag and was denied, so the docs do not mention it.For the maintainer
v1withgit tag -fand a forced push of the tag is a release action I cannot do and did not do.actions/checkout@v4andbawbel/integrations/gate-lint@v1. Once both are merged,Pinswill fail on those two lines until they are changed (a pinnedcheckout, and<release-commit-sha>for gate-lint, which no release contains). I will update whichever PR lands second.🤖 Generated with Claude Code
https://claude.ai/code/session_015T9K217kxBqsUZ3omKYv9P