chore: upgrade pnpm to 11.9.0 - #1781
Conversation
3e3324b to
1a3853c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/gcbrun |
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1781-331fqimk.web.app |
|
Temporary Url for review: https://strr-platform-dev--pr-1781-3viy7v9o.web.app |
|
Temporary Url for review: https://strr-examiner-dev--pr-1781-hitdz37x.web.app |
|
Temporary Url for review: https://strr-hosts-dev--pr-1781-t1669sum.web.app |
599e7c8 to
cc0934e
Compare
|
@jimmypalelil - this PR is fully green (CI/SonarCloud/Cloud Build preview all pass) and ready to merge. If you'd like to validate on the real dev environment before merging, could you push this branch into bcgov/STRR as |
| extends: [ | ||
| ['github:bcgov/STRR/strr-base-web', { install: true }], | ||
| // '../strr-base-web', // dev only | ||
| '../strr-base-web', |
There was a problem hiding this comment.
will this change actually work for the deployed version?
|
@panish16 I had errros pushing your branch to bcgov/strr. please resolve them and then I can push. thanks |
Pin pnpm_version to 11.9.0 in CI workflows, set packageManager field via corepack, and add pnpm-workspace.yaml with allowBuilds for native deps (@parcel/watcher, esbuild, sharp, unrs-resolver) required under pnpm 11's stricter build-script gating.
pnpm 11's stricter hoisting no longer resolves tailwindcss transitively for eslint-plugin-tailwindcss in examiner/host-pm/platform/strata, crashing eslint entirely (Could not find tailwindcss). It was already present in each lockfile as a transitive dep; declaring it directly fixes resolution without changing the resolved version (3.4.19).
The git-hosted layer reference (github:bcgov/STRR/strr-base-web) is cloned by giget into an isolated node_modules/.c12/<hash> tree with no node_modules of its own, so its tsconfig.json (and anything depending on generated .nuxt/tsconfig.json) can't resolve under pnpm 11's resolution behavior. This broke nuxt prepare for all 4 downstream apps, which in turn broke both eslint's typescript/import resolvers (200+ spurious lint errors) and the Nuxt build itself. Switching to a local relative-path extends avoids the git-clone isolation entirely. Since the sibling app's own .nuxt/tsconfig.json may not exist in a fresh checkout (CI only runs each app's own nuxt prepare), each consuming app eagerly installs and prepares strr-base-web if missing, before Nuxt evaluates its config.
All 4 STRR frontend CD files (examiner/host-pm/platform/strata) were still hardcoded to pnpm_version: 10.0.0, unrelated to and never touched by the pnpm-v11 CI migration on this branch.
Picker.vue uses raw @use 'tailwindcss/base'/'components'/'utilities' imports, but strr-base-web never declared tailwindcss itself as a dependency - it only worked by relying on hoisting from whichever app extended the layer. Under pnpm v11's stricter per-package node_modules, that resolution fails, breaking strr-host-pm-web's build/tests since it's the only app that actually renders ConnectFormDateInput.
…spec ConnectFeeInfo.* strings live only in strr-base-web's own locale file. Under mountSuspended, the real @nuxtjs/i18n module doesn't merge that layer's locale file in, so the component's auto-imported useI18n() resolved against messages missing those keys - independent of the test's own baseEnI18n mock, which was only ever used to compute the expected assertion values, not to back the rendered component. Stub useI18n via mockNuxtImport (already used elsewhere in this test suite for other auto-imports) so the component resolves against the same baseEnI18n messages the assertions are built from.
…re shim
Sonar flagged execSync('npx --yes pnpm install ...')/('npx --yes nuxi
prepare ...') in all 4 apps' nuxt.config.ts (typescript:S4036 - PATH
search for the executed command). Replace with pre-resolved absolute
paths: corepack (bundled next to the running node binary, so still
honours strr-base-web's own pinned packageManager version the same
way npx did) for the install step, and nuxt's own package.json 'bin'
field (the same lookup pnpm's own generated shim uses, since nuxt's
'exports' map doesn't expose './bin/nuxt.mjs' for require.resolve)
for the prepare step.
Verified locally via a simulated fresh checkout (node_modules/.nuxt
deleted) that both steps still run and the build completes.
… module The PATH-avoidance fix from the previous commit was correct but duplicated the same ~27 lines across all 4 apps' nuxt.config.ts, which pushed SonarCloud's New Code duplication gate from 7.2% to 15.6%. Move the logic into strr-base-web/prepare.mjs (a plain module with no external deps of its own, safe to import even before strr-base-web's own node_modules exists) and have each app just call ensureStrrBaseWebPrepared(). Verified locally via a simulated fresh checkout that both the prepare step and the full build still succeed.
599e7c8 to
6c73344
Compare
|
@jimmypalelil Fixed - Should push cleanly to On the 1. Layer extends: git-hosted → local relative path 2. Eager-prepare shim: PATH lookup → pre-resolved absolute paths Both are verified locally via a simulated fresh checkout (deleting |
…bsent The official CD deploy pipeline's Docker build context is scoped to each app's own directory only (bcgov/bcregistry-sre's Dockerfile-build does `COPY . /app` from whatever `gcloud builds submit` was invoked with, which frontend-cd.yaml scopes to just working_directory) - strr-base-web is never uploaded alongside it there, unlike CI/local dev/the Cloud Build PR-preview channel, which all have the full repo checked out. Confirmed live: a real deploy attempt failed with `Cannot find module '../strr-base-web/prepare.mjs'` since the whole directory doesn't exist in that build context, not just its node_modules. Add ensure-strr-base-web.mjs, a preinstall script (runs before pnpm even resolves dependencies) that clones strr-base-web fresh from GitHub main when the sibling directory is missing outright - matching what the old git-hosted `extends` layer reference used to do at build time regardless of local checkout contents, before an earlier commit on this branch switched to a local relative path to fix pnpm 11's resolution of that reference. This can't live inside nuxt.config.ts itself: jiti (its loader) resolves import()s ahead of the file's own runtime code executing, so a dynamic import can't depend on a clone step run a few lines above it in the same file - confirmed by testing an in-config version first, which failed identically even with the file already cloned to disk by that point. It's necessarily identical across all 4 apps (each one's CD build context is a fully isolated Docker build containing only that app's own directory, so unlike its normal-case counterpart strr-base-web/prepare.mjs, there's nothing to import it from) - excluded from SonarCloud's copy-paste detection accordingly, following the same sonar.cpd.exclusions pattern already used for test files. Verified locally: the preinstall script correctly clones and the subsequent nuxt prepare + build succeed when strr-base-web is deleted first (simulating the CD pipeline's actual build context), and nothing regresses in the normal case where it's already present. Known limitation: this fetches whatever's on bcgov/STRR's main, not this PR's own branch - correct for real dev/test/prod deploys once this merges (main will have the matching strr-base-web changes by then), but a manual pre-merge validation deploy of this branch alone (e.g. jimmy's feature-pnpm-v11-validate push) would still get a stale strr-base-web missing this PR's own fixes to it.
b9ad191 to
ff45ad4
Compare
|
@jimmypalelil Found and fixed the real cause of the deploy failure - it is related to pnpm v11, specifically a regression from this PR's own earlier fix (not a pre-existing issue). Root cause: the official CD deploy pipeline's Docker build context only ever contains each app's own directory - Fix: added a One known limitation worth flagging: it fetches whatever's on CI and SonarCloud are both green again on the current commit. Could you retry pushing the branch to |
jimmy's real deploy attempt (via feature-pnpm-v11-validate on bcgov/STRR) confirmed the preinstall script itself now runs correctly, but failed with 'git not found on PATH' - the actual CD build image (an Alpine-based firebase-repo image) doesn't have git installed at all, unlike this branch's own local testing environment. Replace the git clone with a plain HTTPS fetch of GitHub's codeload tarball (https://codeload.github.com/bcgov/STRR/tar.gz/refs/heads/main) plus a small hand-rolled tar reader (ustar headers + pax extended headers for long paths, same format git archive/GitHub both produce) using only Node builtins (fetch, zlib, fs) - no external binary dependency at all, so it works regardless of what's installed in whatever build image this runs in, and there's no PATH-dependent command to trip SonarCloud typescript:S4036 in the first place. Verified locally against the real bcgov/STRR tarball (extracted content is byte-identical to a real git checkout, modulo line-ending normalization from this Windows dev environment) and, pointed temporarily at this branch's own fork/ref to include its otherwise main-only-missing prepare.mjs, confirmed the full nuxt prepare + build succeeds end-to-end.
|
6 participants
Fresh PR replacing #1747 (closed while testing was still in progress).
Scoped strictly to pnpm 11.9.0: version pins (
pnpm_version,packageManager,pnpm/action-setup@v6),--ignore-scriptswhere needed, and pinning the smoke-test workflows off the floatinglatest-11tag.Note: strr-examiner-web, strr-host-pm-web, strr-platform-web, and strr-strata-web will still fail
verify-build— this is the pre-existing, already-known upstream Nuxt/c12#importsresolution bug for git-hosted layers (unrelated to pnpm, confirmed via A/B test against the pre-pnpm-11 code). Deliberately left unfixed here per @panish16's request to keep this PR pnpm-only.