REGBACKLOG-336: manage STRR dev infrastructure with Terraform - #1790
Open
Jacky-Pham wants to merge 3 commits into
Open
REGBACKLOG-336: manage STRR dev infrastructure with Terraform#1790Jacky-Pham wants to merge 3 commits into
Jacky-Pham wants to merge 3 commits into
Conversation
Jacky-Pham
marked this pull request as ready for review
August 25, 2026 21:02
bolyachevets
approved these changes
Aug 25, 2026
Collaborator
Author
|
hey Jimmy, the SRE IAM changes are merged and applied now. when you have a chance can you review this so I can run the terraform plan? |
|
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds dev-only Terraform management for existing STRR Pub/Sub and Eventarc infrastructure.
Changes:
- Defines and imports existing dev resources.
- Configures remote state and keyless authentication.
- Adds manual Terraform plan/apply automation.
File summaries
| File | Description |
|---|---|
terraform/versions.tf |
Configures Terraform, provider, and backend. |
terraform/variables.tf |
Defines dev infrastructure inputs. |
terraform/README.md |
Documents scope and rollout. |
terraform/pubsub.tf |
Manages and imports Pub/Sub resources. |
terraform/eventarc.tf |
Manages and imports the Eventarc trigger. |
terraform/dev.tfvars |
Supplies dev environment values. |
terraform/data.tf |
Resolves the Pub/Sub service agent. |
terraform/.terraform.lock.hcl |
Locks the Google provider. |
.gitignore |
Excludes Terraform working directories. |
.github/workflows/strr-terraform.yaml |
Adds manual plan/apply automation. |
Review details
Files not reviewed (1)
- terraform/.terraform.lock.hcl: Generated file
- Files reviewed: 8/10 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+69
to
+71
| - name: Terraform apply | ||
| if: inputs.action == 'apply' | ||
| run: terraform apply -input=false -auto-approve tfplan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Safety boundary
This first change transfers existing dev resources into Terraform state. It does not add the missing cross-environment parity resources. Those changes will be reviewed separately after the import produces a clean plan. Apply is restricted to main.
Dependencies
Both IAM changes must be applied and merged before running this workflow.
Local validation
Initial rollout
Ticket: https://hous-hpb.atlassian.net/browse/REGBACKLOG-336